node: tls: accept ALPNProtocols for undici compatibility#6546
Open
KevinSailema wants to merge 2 commits intocloudflare:mainfrom
Open
node: tls: accept ALPNProtocols for undici compatibility#6546KevinSailema wants to merge 2 commits intocloudflare:mainfrom
KevinSailema wants to merge 2 commits intocloudflare:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
37933d6 to
d001109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6527
This change fixes a Node.js compatibility issue where TLS connections failed with:
The options.ALPNProtocols option is not implemented
In practice, this was breaking @elastic/elasticsearch usage on Workers because Undici passes ALPNProtocols by default on HTTPS connections.
Root cause
The TLS compatibility layer in internal_tls_wrap.ts explicitly rejected options.ALPNProtocols, even though this option is commonly set by upstream clients and connectors.
What changed
Why this is safe
Validation