Add CI workflow to run the validator test suites - #33
Open
Kaushik2210 wants to merge 1 commit into
Open
Kaushik2210 wants to merge 1 commit into
Kaushik2210 wants to merge 1 commit into
Conversation
The repo has no automated CI: tests only run when a contributor remembers to run them locally. This directly let a real bug through — validate-findings.test.cjs had 7 CLI tests that failed outright (not just skipped) on platforms without O_NOFOLLOW/O_NONBLOCK, such as Windows (see PR cloudflare#31) — and nothing would have caught it before merge. Add a GitHub Actions workflow that runs both validate-findings.test.cjs and validate-coverage-ledger.test.cjs on push/PR to main, across ubuntu-latest, windows-latest, and macos-latest. Verified locally that running the pre-fix test file exits nonzero, confirming this workflow would have failed on the bug fixed in cloudflare#31. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo has no automated CI — the two test suites (
validate-findings.test.cjs,validate-coverage-ledger.test.cjs) only run when a contributor remembers to run them locally before opening a PR.This isn't hypothetical: it's exactly how the bug fixed in #31 got through.
validate-findings.test.cjshad 7 CLI-invoking tests that failed outright (rather than skipping) on any platform withoutO_NOFOLLOW/O_NONBLOCK— e.g. Windows — and nothing flagged it before merge.Change
Adds
.github/workflows/test.yml, which runs both validator test suites on push/PR tomain, acrossubuntu-latest,windows-latest, andmacos-latest.Verification
Confirmed locally that running
validate-findings.test.cjsat the commit before #31's fix exits with a nonzero status code — so this workflow, had it existed, would have failed CI on the Windows job and caught that bug before merge.This PR is independent of #31 (based on current
main) and can land in either order; together they close the gap that let that bug ship.🤖 Generated with Claude Code