Prevent Generated Chart Search Results from Pointing to Nonexistent Docs#641
Open
anott03 wants to merge 2 commits into
Open
Prevent Generated Chart Search Results from Pointing to Nonexistent Docs#641anott03 wants to merge 2 commits into
anott03 wants to merge 2 commits into
Conversation
Contributor
Author
|
/bonk please review |
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Nice cleanup. Removing the invalid doc links and redirecting the map components to the correct documentation improves the search experience. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the auto-generated search results for Chart components point to nonexistent paths:
/components/chart,/components/bubble-map, etc. Most of these have guides already, so the generated search results were redundant, so removing them was sufficient.BubbleMapandChoroplethMap, however, are documented in the "Maps" guide, which is not listed as a result when searching for those components. In those cases, add overrides that direct them to/charts/maps.