Skip to content

[kumo] Preserve timeseries brush after option updates#634

Open
Ankcorn wants to merge 1 commit into
cloudflare:mainfrom
Ankcorn:tankcorn/fix-timeseries-brush-option-updates
Open

[kumo] Preserve timeseries brush after option updates#634
Ankcorn wants to merge 1 commit into
cloudflare:mainfrom
Ankcorn:tankcorn/fix-timeseries-brush-option-updates

Conversation

@Ankcorn

@Ankcorn Ankcorn commented Jul 17, 2026

Copy link
Copy Markdown
Member

TimeseriesChart enables ECharts’ global brush cursor once when zoom is configured. A later setOption({ notMerge: true }) clears that cursor, leaving drag-to-zoom disabled after data updates.

Reactivate the brush whenever a notMerge options update occurs. This keeps full option replacement available to consumers without silently breaking zoom. Includes a regression test with deployment markers and updated series data.


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: no automated review tool is available in this environment
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Jul 17, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@634

commit: 6e8f7c8

@github-actions

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 6e8f7c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant