Repository navigation
feat(metrics): add clear_all to stop reporting unchanged series - #280
Open
MariamFahmy98 wants to merge 2 commits into
Open
MariamFahmy98 wants to merge 2 commits into
MariamFahmy98 wants to merge 2 commits into
Conversation
Signed-off-by: Mariam <mariam@cloudflare.com>
TheJokr
reviewed
Oct 16, 2026
Signed-off-by: Mariam <mariam@cloudflare.com>
MariamFahmy98
marked this pull request as ready for review
October 22, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draining process keeps exporting every series it ever created, even though most of them stop changing once it no longer serves traffic.
This PR adds a
clear_allfunctionality, which snapshots the value of every registered series. Collection then skips each series whose value still matches the snapshot. A series that changes is reported with its current value and stays reported, so graphs don't get gaps. Series and metrics created after the call, and info metrics, are always reported. Values aren't reset, so existing handles keep working, and calling it again starts over from the values at that time.Also,
RangeGaugeresets its min and max when read, so the snapshot reads each metric twice and keeps the second result. Without that, an idle gauge would never match and would be reported forever.