Repository navigation
fix(pytest): preserve node separators inside parameter IDs - #1411
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest parameter IDs can contain
::. Splitting the full node ID on every separator treats those parameter contents as class/test delimiters. For example,tests/test_mod.py::TestClass::test_value[left::right]loses the class and records the testcase asright]. This affects both subset requests and pytest-reportlog imports.Split the file path first, then split only the qualified test name before the parameter suffix. Preserve the complete suffix, including additional brackets and separators. Existing file, class, and unparameterized handling stays unchanged.
Four regressions fail before the fix: function parameters, class parameters with multiple separators/brackets, the mocked public
subset pytestCLI request, and a JSON report import. Added a control for brackets in the file path.Validation using the locked development environment, Python 3.13:
git diff --checkpass.Tests use local report files and mocked HTTP/local servers; no hosted report upload or credentials used. Java/Bazel tests and the Windows/Linux matrix were not run. Developed with Codex assistance and verified locally.