Skip to content

Compare-and-update progress steps so a stale write cannot rewind the bar - #551

Merged
Dany9966 merged 2 commits into
cloudbase:mainfrom
fabi200123:compare-then-update-progress-bars
Nov 6, 2026
Merged

Dany9966 merged 2 commits into
cloudbase:mainfrom
fabi200123:compare-then-update-progress-bars

Conversation

@fabi200123

Copy link
Copy Markdown
Contributor

This PR adds the following:

  • updates the progress bar logic so the task and minion-pool progress updates now advance current_step only when the stored step is not already ahead, including a completed update that a late cast would otherwise overwrite
  • adds an integration test that checks the progress update logic

…bar.

Task and minion-pool progress updates now advance current_step only when the stored step is not already ahead, including a completed update that a late cast would otherwise overwrite.
@fabi200123
fabi200123 force-pushed the compare-then-update-progress-bars branch from 5b478a1 to c74aa95 Compare October 26, 2026 08:10

@mihaelabalutoiu mihaelabalutoiu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dany9966
Dany9966 merged commit d33f417 into cloudbase:main Nov 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants