Repository navigation
Conversation
|
Review of 7dae88a (andrei/update_doc) Checked against a clean HighA current page sends the reader to a missing target.
MediumThe new pages work. Older addresses and two platforms are hard to reach.
Low
— Grok |
|
Cloudstack and Nutanix are still missing from the Platforms list |
|
LGTM! |
…ry to keep track more easily of md files. Created a new suse-linux-kvm-plugin.md file as a Work in progress file
|
|
||
| **Coriolis** integrates the platform Plugin on the Appliance itself, this way there is no need for agents to be deployed on platforms to establish the communication between the platform and the Coriolis components. Using this type of architecture, **Coriolis** guarantees the connection to the supported platform set up to be used as either Source or Destination, as long as the requirements are met. | ||
|
|
||
| ## WORK IN PROGRESS |
There was a problem hiding this comment.
This is not mergeable. Please complete the doc if you have anything else to add or remove this line.
|
|
||
| **Coriolis** integrates the platform Plugin on the Appliance itself, this way there is no need for agents to be deployed on platforms to establish the communication between the platform and the Coriolis components. Using this type of architecture, **Coriolis** guarantees the connection to the supported platform set up to be used as either Source or Destination, as long as the requirements are met. | ||
|
|
||
| ## WORK IN PROGRESS |
|
|
||
| **Coriolis** integrates the platform Plugin on the Appliance itself, this way there is no need for agents to be deployed on platforms to establish the communication between the platform and the Coriolis components. Using this type of architecture, **Coriolis** guarantees the connection to the supported platform set up to be used as either Source or Destination, as long as the requirements are met. | ||
|
|
||
| ## WORK IN PROGRESS |
Cristi1324
left a comment
There was a problem hiding this comment.
Review, model: Grok 4.7
1 high, 1 medium, 1 low. 3 confirmed, 0 suspected.
Not approved.
Reviewed at 6254b315bc5336a222d275deb17f2495cb018979. AI agents wrote these findings, and a person chose to post them. Suspected findings are unproven. Findings on the diff are inline comments.
get_provider keeps a provider only when cls.platform == platform_name. PLATFORM_STACKIT is stackit. The medium finding is the three comments Dany9966 already wrote.
Tested
sphinx-build -M html source buildwith Sphinx 9.1.0 and myst-parser 5.1.0 built commit6254b315bc5336a222d275deb17f2495cb018979. The build wrote 88 source files. The warning log was empty. Every internal HTML and image link resolved. All 34 platform links on the Getting Started page resolved.coriolis_provider_stackit/common.py:41setsPLATFORM_STACKIT = "stackit".imp.py:43andexp.py:40assign that value toplatform.coriolis/providers/factory.py:74usescls.platform == platform_name.- A second
sphinx-build -M html source buildafter the three required edits succeeded. The warning log was empty. The STACKIT cell renderedstackit.WORK IN PROGRESSwas absent. The Proxmox sentence renderedReplica/Migration.
Not run
- A GitHub Pages deploy.
- A
corioliscommand with--provider STACKIT.
Skippable
- Old public URLs have no redirect. This review does not require one.
Withdrawn
- The walkthrough link
http://openstack-coriolis-pluginis handled by #8.
| Plugin identifier| **stackit**| Identifies the plugin. Used for the **–provider** CLI parameter | ||
| Credentials needed| Stackit organization, project, region and service account key.| The service account key is expected to be base64 encoded. | ||
| Deployment requirements| Coriolis worker component(s) need network access to the Stackit API endpoint.| Coriolis deployment and environment connectivity requirements | ||
| Plugin identifier| **STACKIT**| Identifies the plugin. Used for the **–provider** CLI parameter |
There was a problem hiding this comment.
High · confirmed · The table tells the reader to pass STACKIT to --provider.
The diff changes the plugin identifier from stackit to STACKIT. get_provider accepts only an exact match with stackit, so STACKIT raises NotFound.
Why
The provider id is stackit.
Added
- The identifier cell is
stackit.
Evidence
stackit-coriolis-plugin.md:59 writes **STACKIT**. coriolis_provider_stackit/common.py:41 sets PLATFORM_STACKIT to stackit. imp.py:43 and exp.py:40 assign that value to platform. coriolis/providers/factory.py:74 compares cls.platform == platform_name and raises NotFound when the strings differ.
Proposed fix (version 1 of 1, accepted)
This version writes stackit in the identifier cell. The en dash and the two trailing spaces stay.
Suggested change (accepted)
| Plugin identifier| **STACKIT**| Identifies the plugin. Used for the **–provider** CLI parameter | |
| Plugin identifier| **stackit**| Identifies the plugin. Used for the **–provider** CLI parameter |
Discussion with the review agent
Version 1 of 1 was accepted.
model: Grok 4.7
There was a problem hiding this comment.
This was a very good catch
|
|
||
| ## WORK IN PROGRESS | ||
|
|
There was a problem hiding this comment.
Medium · confirmed · The page adds a WORK IN PROGRESS heading.
The diff adds ## WORK IN PROGRESS on line 9. Dany9966 wrote: "This is not mergeable. Please complete the doc if you have anything else to add or remove this line."
Why
Dany9966 said this line is not mergeable.
Added
- The WORK IN PROGRESS heading is removed.
Evidence
cloudstack-coriolis-plugin.md:9 is ## WORK IN PROGRESS. Dany9966 wrote that sentence on this line on 4 Nov 2026.
Proposed fix (version 2 of 2, accepted)
This version removes the WORK IN PROGRESS heading. It adds no other text. Lines 8–10 become one blank line.
Suggested change (accepted)
| ## WORK IN PROGRESS |
Discussion with the review agent
Version 1 added that the Platforms list publishes the page. That version was not accepted. Version 2 of 2 removes the heading and adds no other text. Version 2 was accepted.
model: Grok 4.7
|
|
||
| ## WORK IN PROGRESS | ||
|
|
There was a problem hiding this comment.
Medium · confirmed · The page adds a WORK IN PROGRESS heading.
The diff adds ## WORK IN PROGRESS on line 9. Dany9966 wrote: "Same as above."
Why
Dany9966 said this line is not mergeable.
Added
- The WORK IN PROGRESS heading is removed.
Evidence
nutanix-coriolis-plugin.md:9 is ## WORK IN PROGRESS. Dany9966 wrote "Same as above." on this line on 4 Nov 2026. That refers to the CloudStack comment: "This is not mergeable. Please complete the doc if you have anything else to add or remove this line."
Proposed fix (version 2 of 2, accepted)
This version removes the WORK IN PROGRESS heading. It adds no other text. Lines 8–10 become one blank line.
Suggested change (accepted)
| ## WORK IN PROGRESS |
Discussion with the review agent
Version 1 added that the Platforms list publishes the page. That version was not accepted. Version 2 of 2 removes the heading and adds no other text. Version 2 was accepted.
model: Grok 4.7
|
|
||
| ## WORK IN PROGRESS | ||
|
|
There was a problem hiding this comment.
Medium · confirmed · The page adds a WORK IN PROGRESS heading.
The diff adds ## WORK IN PROGRESS on line 9. Dany9966 wrote: "Same as above."
Why
Dany9966 said this line is not mergeable.
Added
- The WORK IN PROGRESS heading is removed.
Evidence
suse-linux-kvm-plugin.md:9 is ## WORK IN PROGRESS. Dany9966 wrote "Same as above." on this line on 4 Nov 2026. That refers to the CloudStack comment: "This is not mergeable. Please complete the doc if you have anything else to add or remove this line."
Proposed fix (version 2 of 2, accepted)
This version removes the WORK IN PROGRESS heading. It adds no other text. Lines 8–10 become one blank line.
Suggested change (accepted)
| ## WORK IN PROGRESS |
Discussion with the review agent
Version 1 added that the Platforms list publishes the page. That version was not accepted. Version 2 of 2 removes the heading and adds no other text. Version 2 was accepted.
model: Grok 4.7
| ### Proxmox as a destination cloud | ||
|
|
||
| For more information on using Proxmox as a **destination cloud** for Replica/MIgration, please check the **[Proxmox as a destination cloud](../platforms/proxmox-as-a-destination-cloud.md)** page. | ||
| For more information on using Proxmox as a **destination cloud** for Replica/MIgration, please check the **[Proxmox as a destination cloud](../proxmox/proxmox-as-a-destination-cloud.md)** page. |
There was a problem hiding this comment.
Low · confirmed · The Proxmox page keeps the spelling Replica/MIgration.
The diff updates the link on this line and leaves Replica/MIgration. The VMware and AWS lines in the same diff use Replica/Migration.
Why
The same diff already uses Replica/Migration.
Added
- The word is
Replica/Migration.
Evidence
proxmox-coriolis-plugin.md:16 says Replica/MIgration. The built page contains that spelling. The VMware and AWS plugin lines in this diff say Replica/Migration.
Proposed fix (version 1 of 1, accepted)
This version replaces Replica/MIgration with Replica/Migration on this line.
Suggested change (accepted)
| For more information on using Proxmox as a **destination cloud** for Replica/MIgration, please check the **[Proxmox as a destination cloud](../proxmox/proxmox-as-a-destination-cloud.md)** page. | |
| For more information on using Proxmox as a **destination cloud** for Replica/Migration, please check the **[Proxmox as a destination cloud](../proxmox/proxmox-as-a-destination-cloud.md)** page. |
Discussion with the review agent
Version 1 of 1 was accepted.
model: Grok 4.7
Every platform now lives in a specific directory to keep track more easily of md files. Created a new suse-linux-kvm-plugin.md file as a Work in progress file.