Skip to content

refactor(nginx-strangler): route stages to server-nestjs - #2748

Merged
shikanime merged 1 commit into
mainfrom
pr/stage-nginx-routing
Oct 5, 2026
Merged

refactor(nginx-strangler): route stages to server-nestjs#2748
shikanime merged 1 commit into
mainfrom
pr/stage-nginx-routing

Conversation

@shikanime

@shikanime shikanime commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Issues liées

Depends on the server-nestjs stage routes from #2496; safe to merge only with or after it.

Quel est le comportement actuel ?

Decouple the traffic-routing cut-over from the stage module migration so the nginx switch can land and be observed independently of #2496.

Quel est le nouveau comportement ?

Extract the nginx-strangler routing change (/api/v1/stages → server-nestjs) from #2496 into this standalone PR.

Signed-off-by: Shikanime Deva 22115108+shikanime@users.noreply.github.com

@shikanime
shikanime requested a review from a team as a code owner September 18, 2026 08:58
@github-actions github-actions Bot added the built label Sep 18, 2026
@shikanime
shikanime marked this pull request as draft September 18, 2026 09:20
@shikanime
shikanime changed the base branch from main to pr/admin-token-migration September 18, 2026 09:45
@shikanime
shikanime changed the base branch from pr/admin-token-migration to main September 18, 2026 09:45
@shikanime
shikanime changed the base branch from main to pr/stage-strangler September 18, 2026 09:46
@shikanime
shikanime added this pull request to stack #2554 September 18, 2026 09:46
@shikanime
shikanime removed this pull request from stack #2554 September 18, 2026 09:54
@shikanime
shikanime changed the base branch from pr/stage-strangler to pr/stage-migration September 18, 2026 09:54
@shikanime
shikanime added this pull request to stack #2753 September 18, 2026 09:54
@shikanime
shikanime marked this pull request as ready for review September 23, 2026 15:12
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 45a917f to 0258166 Compare September 23, 2026 15:50
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 0258166 to 9688320 Compare September 23, 2026 16:07
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 9688320 to 02fca72 Compare September 23, 2026 16:25
@shikanime shikanime mentioned this pull request Sep 24, 2026
Closed
@shikanime shikanime added this to the 9.27.0 milestone Sep 24, 2026
@shikanime shikanime self-assigned this Sep 24, 2026
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2748.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

StephaneTrebel
StephaneTrebel previously approved these changes Sep 24, 2026
View reviewed changes
StephaneTrebel
StephaneTrebel previously approved these changes Sep 25, 2026
View reviewed changes
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from dc75f9b to c7ecbdf Compare September 25, 2026 12:57
@shikanime

shikanime commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

PR réduite à la bascule nginx.

Le câblage de stage.module.ts (AuthModule, UserPermissionModule) a été déplacé vers #2496, où il appartient : le module migré doit fournir les dépendances de son propre UserGuard.

Diff actuel : apps/nginx-strangler/conf.d/routing.conf uniquement.

@shikanime shikanime mentioned this pull request Sep 25, 2026
Merged
@shikanime shikanime removed the preview Deploy preview app with Argo-cd label Sep 28, 2026
@shikanime shikanime moved this to Backlog in Cloud Pi Native Sep 29, 2026
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch 2 times, most recently from accf4b3 to 474f8a2 Compare October 2, 2026 08:16
@iliesmrf iliesmrf modified the milestones: 9.27.0, 9.28.0 Oct 2, 2026
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 474f8a2 to bec7d63 Compare October 2, 2026 11:56
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch 4 times, most recently from fd03fd1 to 1338e3e Compare October 2, 2026 13:52
StephaneTrebel
StephaneTrebel previously approved these changes Oct 2, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approbation : la route stages cible la migration qui valide désormais les identifiants UUID. Fils résolus et CI verte.

@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 1338e3e to 8bf3263 Compare October 2, 2026 15:09
Base automatically changed from pr/stage-migration to main October 2, 2026 16:35
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 8bf3263 to 794a113 Compare October 2, 2026 16:35
@shikanime @yorha-operator
feat(nginx-strangler): router les stages vers server-nestjs
4e7d734 
Co-authored-by: Automata <automata@shikanime.studio>
@shikanime
shikanime force-pushed the pr/stage-nginx-routing branch from 794a113 to 4e7d734 Compare October 2, 2026 16:53
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Oct 2, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

StephaneTrebel
StephaneTrebel previously approved these changes Oct 5, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La route est plus spécifique que le fallback , reste placée avant celui-ci et cible correctement server-nestjs. Les fils sont résolus et la CI est verte.

@StephaneTrebel
StephaneTrebel dismissed their stale review October 5, 2026 07:33

Revue remplacée : le shell a supprimé les chemins entre accents graves du verdict.

StephaneTrebel
StephaneTrebel approved these changes Oct 5, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La route /api/v1/stages est plus spécifique que le fallback /api/, reste placée avant celui-ci et cible correctement server-nestjs. Les fils sont résolus et la CI est verte.

@shikanime
shikanime added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 703baff Oct 5, 2026
34 checks passed
@shikanime
shikanime deleted the pr/stage-nginx-routing branch October 5, 2026 10:34
@iliesmrf iliesmrf modified the milestones: 9.28.0, 9.27.0 Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes
+1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@shikanime shikanime

Labels

built refactor Refactor code

Projects

None yet

Milestone

9.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shikanime @StephaneTrebel @iliesmrf