Skip to content

test(server-nestjs): parité reconcile-only des rôles admin keycloak + garde d'émission #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shikanime wants to merge 3 commits into from
Closed

test(server-nestjs): parité reconcile-only des rôles admin keycloak + garde d'émission #2581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2459a0
test(server-nestjs): assert app events emit surface parity
shikanime Sep 9, 2026
af9265f
test(server-nestjs): drop cutover guard forbidding emitAdminRoleEvent
shikanime Oct 2, 2026
c593107
test(events): drop the emitZoneEvent absence guard superseded by the …
shikanime Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/server-nestjs/src/modules/events/app-events.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,13 @@ describe('appEventsService', () => {
data: expect.objectContaining({ args: payload }),
}))
})

describe('emit surface (migration parity)', () => {
const expectedEmitMethods = ['emitProjectEvent', 'emitProjectMemberEvent', 'emitRepositoryEvent'] as const

it.each(expectedEmitMethods)('exposes %s as a public emit entrypoint', (method) => {
expect(typeof service[method]).toBe('function')
})

})
})
24 changes: 24 additions & 0 deletions apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,4 +526,28 @@ describe('keycloakService', () => {
expect(keycloak.removeUserFromGroup).toHaveBeenCalledWith('user-2', 'system-managed-id')
})
})

describe('migration parity: admin-role event path (legacy hook.adminRole.*)', () => {
const adminRoles: AdminRoleWithDetails[] = [
{ id: 'admin-role-1', name: 'admin', permissions: 0n, position: 0, oidcGroup: '/admin-group', type: 'managed' },
]
const users: UserWithAdminRoles[] = [
{ id: 'user-1', adminRoleIds: ['admin-role-1'] },
]

it('syncs admin-role OIDC groups via cron reconcile ONLY (no event path exists)', async () => {
datastore.getAllProjects.mockResolvedValue([])
datastore.getAllAdminRoles.mockResolvedValue(adminRoles)
datastore.getAllUsersWithAdminRoleIds.mockResolvedValue(users)

const adminGroup = makeGroupRepresentation({ id: 'kc-parity-group-id', name: 'admin', path: '/console/parity-admin' })
keycloak.getOrCreateGroupByPath.mockResolvedValue(adminGroup)
keycloak.getGroupMembers.mockResolvedValue([])

await service.handleCron()

expect(keycloak.getOrCreateGroupByPath).toHaveBeenCalledWith('/admin-group')
expect(keycloak.addUserToGroup).toHaveBeenCalledWith('user-1', 'kc-parity-group-id')
})
})
})
Loading