Google login and register - #255
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This is a pre-release build of google-login-register (Google Sign-In) merged with the latest trunk, meant for manual install on production to validate before merging. readme.txt's Stable tag is intentionally left untouched — this is not a WordPress.org release.
trunk's tabbed settings rebuild replaced the old "render every registered section automatically" loop with a fixed, hardcoded list of tab panels. The Google Sign-In section still registers correctly via the documented frontblocks_register_settings extension hook, but no tab panel called render_section_if_exists() for it, so it silently never rendered anywhere after merging trunk in. Placed outside the main settings <form>, matching the License tab: Google Sign-In manages its own form/nonce/save handling rather than going through the shared frontblocks_settings option.
- Add docs/GOOGLE-SIGNIN.md covering settings, the sign-in flow (button -> Google Identity Services -> server-side ID token verification -> account matching/creation), security notes, and the two extension hooks it fires. - Link it from readme.md and add a Functionalities bullet. - Add a readme.txt feature description and a 1.6.0 changelog entry. All following AGENTS.md's "Adding New Features" documentation checklist, in English per the plugin's language convention.
Keeps it a patch bump on top of the current 1.5.2, matching the 1.5.3-beta.1 version already used for the test build.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # includes/Admin/Settings.php # readme.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 564ef74580
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
Fixes #246