Switch Plugin Check CI to official plugin-check-action - #294
Merged
Merged
Conversation
Replace the manual wp-cli/SQLite bootstrap with WordPress/plugin-check-action@v1, which handles the wp-env/WordPress setup itself. Gate results with error-severity=7 and warning-severity=8 thresholds. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
The first Plugin Check run flagged 9 dev-only files/dirs already stripped from the distributed plugin via .distignore (.github, bin/, .npmrc, .phpcs.xml.dist, phpstan.neon.dist, phpunit.xml.dist, .gitignore, .distignore, AGENTS.md, CLAUDE.md) as hidden_files/application_detected/ unexpected_markdown_file errors and warnings. Exclude them from the scan via exclude-directories/exclude-files. Also add .pcpignore, ready for when Plugin Check ships its opt-in --use-pcpignore flag (WordPress/plugin-check#1459, PR #1460), so local and WP-CLI scans can skip the same non-distributed paths without per-invocation flags. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- register_setting() now sanitizes formscrm_slack_webhook_url (esc_url_raw) and formscrm_error_notification_email (sanitize_email) instead of accepting raw input. - Bump readme.txt "Tested up to" to 7.1 (current WP release). - Exclude .pcpignore itself from the scan and .distignore, since it's a dev-only file like .gitignore. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sanitize_email() strips commas, which would break the documented comma-separated multi-recipient feature (readme.txt "you can add multiple emails separated by commas", consumed as-is by wp_mail() in helpers-functions.php). Sanitize and validate each address separately instead, dropping invalid ones, and keep the list joined by commas. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/plugin-check.ymlfor the officialWordPress/plugin-check-action@v1, which handles the wp-env/WordPress setup itself.error-severity: 7andwarning-severity: 8thresholds.exclude-directories: vendor,node_modules,testsand the existing trigger/concurrency rules unchanged.Test plan
Plugin Checkworkflow run passes on this PRCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com