Repository navigation
feat(expo): support Expo SDK 58 #9791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9176baf
test(e2e): move the Expo native e2e matrix to SDK 58 beta
wobsoriano 8dbc730
fix(expo): build the Android module on Expo SDK 58
wobsoriano 8a71b41
feat(expo): drop the upper bound on the expo peer range
wobsoriano 6f74917
test(e2e): build the Expo native fixture on SDK 57 instead of 55
wobsoriano 7447f2a
Delete .changeset/expo-native-sdk-58-beta.md
wobsoriano 2f22e71
test(e2e): build the Expo native fixture on the peer floor only
wobsoriano 1525fd0
chore: update changeset
wobsoriano 0d8feab
chore: update changeset and revert peer
wobsoriano 3b6fc3e
Merge remote-tracking branch 'origin/main' into rob/expo-sdk-58
wobsoriano b95db69
test(e2e): build the Expo native fixture on stable SDK 58
wobsoriano c8513e8
fix(expo-native-components): carry the SDK 58 Android fix over from @…
wobsoriano da903b5
Merge branch 'main' into rob/expo-sdk-58
wobsoriano 2ccfd0b
fix(expo-biometrics): build on Expo SDK 58 iOS
wobsoriano bf85b1b
test(e2e): build the Expo native fixture on SDK 55 instead of 54
wobsoriano ed8b564
chore(repo): tidy Expo SDK 58 changesets
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/expo-native-components': patch | ||
| --- | ||
|
|
||
| Fix Android builds on Expo SDK 58. Compiling `@clerk/expo-native-components` no longer fails with `Unresolved reference 'LocalSavedStateRegistryOwner'`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/expo-biometrics': patch | ||
| --- | ||
|
|
||
| Fix iOS builds on Expo SDK 58. `@clerk/expo-biometrics` no longer fails to compile with `cannot override with a stored property 'message'`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@clerk/expo': minor | ||
| '@clerk/expo-passkeys': minor | ||
| '@clerk/expo-google-signin': minor | ||
| '@clerk/expo-native-components': minor | ||
| '@clerk/expo-biometrics': minor | ||
| --- | ||
|
|
||
| Add Expo SDK 58 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ packages: | |
|
|
||
| catalogs: | ||
| peer-expo: | ||
| expo: '>=54 <58' | ||
| expo: '>=54 <59' | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we'll retire SDK 54 next major |
||
| peer-react: | ||
| react: ^18.0.0 || ~19.0.3 || ~19.1.4 || ~19.2.3 || ~19.3.0-0 | ||
| react-dom: ^18.0.0 || ~19.0.3 || ~19.1.4 || ~19.2.3 || ~19.3.0-0 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Test the declared peer floor in the native matrix.
The stated peer range starts at SDK 54, but these entries still select SDK 55. The native jobs therefore do not validate the minimum supported version and retain the SDK 55 build slot that the PR objective says to remove. Change both entries to SDK 54 and keep the SDK 58 E2E entries.
Also applies to: 51-51
🤖 Prompt for AI Agents