Skip to content

feat(ui): add passkey management to UserProfile - #9781

Merged
austincalvelage merged 25 commits into
mainfrom
austin/passkeys-section-actions
Sep 17, 2026
Merged

austincalvelage merged 25 commits into
mainfrom
austin/passkeys-section-actions

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Adds passkey renaming and removal confirmation to the UserProfile Security section.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3add645

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 17, 2026 11:43pm UTC
swingset Ready Ready Preview Sep 17, 2026 11:43pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: dd0b1e53-eced-4448-a540-7ddf2a1db3de

📥 Commits

Reviewing files that changed from the base of the PR and between 28872c7 and 6b05850.

📒 Files selected for processing (17)
  • .changeset/calm-passkeys-views.md
  • packages/mosaic/src/features/user-profile/__tests__/user-profile-passkeys-section.view.test.tsx
  • packages/mosaic/src/features/user-profile/__tests__/user-profile-security-panel.view.test.tsx
  • packages/mosaic/src/features/user-profile/user-profile-passkey-row.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-passkeys-section.messages.ts
  • packages/mosaic/src/features/user-profile/user-profile-passkeys-section.styles.ts
  • packages/mosaic/src/features/user-profile/user-profile-passkeys-section.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-rename-passkey.controller.ts
  • packages/mosaic/src/features/user-profile/user-profile-rename-passkey.dialog.tsx
  • packages/mosaic/src/features/user-profile/user-profile-security-panel.styles.ts
  • packages/mosaic/src/features/user-profile/user-profile-security-panel.view.tsx
  • packages/swingset/src/lib/registry.ts
  • packages/swingset/src/stories/fixtures/user-profile-passkeys.ts
  • packages/swingset/src/stories/fixtures/user-profile.ts
  • packages/swingset/src/stories/user-profile-passkeys-section.mdx
  • packages/swingset/src/stories/user-profile-passkeys-section.stories.tsx
  • packages/swingset/src/stories/user-profile-security-panel.stories.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The passkey section now uses dedicated rows, rename dialogs, localized messages, empty states, add errors, and asynchronous removal. The security panel supports passkey visibility, rename callbacks, add errors, and asynchronous removal. Shared fixtures power the stories, including unavailable and recoverable-error cases. New tests cover rendering, actions, dialogs, focus, errors, retries, pending operations, and empty states.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: 🟡 Moderate · up to 6b058

Valid passkey names cannot always be saved, and the feature lacks release metadata. Resolve these issues before merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 4.17% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 25 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding passkey management to the UserProfile UI.
Description check ✅ Passed The description directly matches the changeset by identifying passkey renaming, removal confirmation, and the new UserProfile Security section feature.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 4.17% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 25 files. (2 skipped: 2 unsupported.)


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9781

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9781

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9781

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9781

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9781

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9781

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9781

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9781

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9781

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9781

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9781

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9781

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9781

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9781

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9781

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9781

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9781

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9781

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9781

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9781

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9781

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9781

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9781

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9781

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9781

commit: 3add645

@austincalvelage austincalvelage changed the title feat(ui): add passkey management to experimental UserProfile feat(ui): add passkey management to UserProfile Sep 16, 2026
@austincalvelage
austincalvelage force-pushed the austin/passkeys-section-actions branch from f544b09 to c0280b5 Compare September 16, 2026 19:38
@austincalvelage
austincalvelage force-pushed the austin/passkeys-section-actions branch from 1e864ca to a37f88f Compare September 16, 2026 21:40
@vercel
vercel Bot temporarily deployed to Preview – clerk-js-sandbox September 16, 2026 22:09 Inactive
austincalvelage and others added 24 commits September 17, 2026 17:26
@austincalvelage
austincalvelage force-pushed the austin/passkeys-section-actions branch from 5f1717b to 3add645 Compare September 17, 2026 23:40
@austincalvelage
austincalvelage enabled auto-merge (squash) September 17, 2026 23:50
@austincalvelage
austincalvelage merged commit 222cc37 into main Sep 17, 2026
49 checks passed
@austincalvelage
austincalvelage deleted the austin/passkeys-section-actions branch September 17, 2026 23:51

This branch was successfully deployed

2 active deployments
Preview – swingset — 3add645c Deployed Sep 17, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 3add645c Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants