fix(mosaic): localize passkey cancellation and failure errors by austincalvelage · Pull Request #10519 · clerk/javascript

austincalvelage · 2026-10-29T02:02:12Z

Description

Cancelling the passkey prompt during reverification showed the browser's raw error instead of the localized copy legacy shows. In Chrome:

Before: "The operation either timed out or was not allowed. See: https://www.w3.org/TR/webauthn-2/#sctn-privacy-considerations-client."
After: "Passkey verification was cancelled or timed out." (matches legacy)

Reverification now resolves Clerk runtime errors by code through toLocalizableError and useErrorText, like the rest of Mosaic. Server errors keep showing the server's message, as legacy does in en-US.

Two passkey failures that previously fell back to "Something went wrong" now get their own copy:

passkey_registration_failed (adding a passkey, the device returns no credential): "Your device couldn't create a passkey. Please try again."
passkey_retrieval_failed (reverification, the device returns no credential): "Your device couldn't verify your passkey. Please try again."

Legacy shows clerk-js's raw English message for these ("Browser failed to create credential").

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

vercel · 2026-10-29T02:02:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 29, 2026 2:05am UTC
swingset	Ready	Preview	Oct 29, 2026 2:05am UTC

changeset-bot · 2026-10-29T02:02:19Z

🦋 Changeset detected

Latest commit: adb318c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-10-29T02:02:32Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: austin/passkey-cancellation-error
File: .coderabbit.yaml
Commit: adb318c
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: ff33c1cc-4c52-4abe-9d4e-6b6219506d00

Commits

Reviewing files that changed from the base of the PR and between cb8638a and adb318c.

Files selected for processing: 6

.changeset/mosaic-reverification-passkey-cancel.md
packages/mosaic/src/features/reverification/__tests__/reverification.feature.test.tsx
packages/mosaic/src/features/reverification/reverification.controller.ts
packages/mosaic/src/features/reverification/reverification.utils.ts
packages/mosaic/src/features/user-profile/user-profile-passkeys-section/__tests__/user-profile-passkeys-section.feature.test.tsx
packages/mosaic/src/localization/errors.messages.ts

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected)
clerk/clerk-ios (auto-detected)
clerk/cli (auto-detected)

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.

Walkthrough

Reverification errors now display server-provided details when available. Otherwise, the controller localizes the error description and uses a generic message as a fallback. New messages and tests cover passkey cancellation, retrieval failure, and failed registration when credential creation returns null.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

clerk/javascript#10458: Updates the reverification localization contract used by the controller’s error fallback.
clerk/javascript#10518: Changes reverification errors to use localizable descriptions and useErrorText.

Suggested reviewers: ephem, alexcarpenter

Merge Risk: Minimal · up to adb31

This change localizes passkey cancellation and failure messages during reverification and when adding a passkey. No actionable merge-blocking risk remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: localizing passkey cancellation and failure errors in Mosaic.
Description check		The description directly explains the localized passkey cancellation and failure behavior, including the affected error cases and expected user-facing messages.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 5 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-29T02:05:26Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10519

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10519

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10519

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10519

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10519

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10519

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10519

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10519

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10519

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10519

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10519

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10519

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10519

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10519

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10519

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10519

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10519

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10519

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10519

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10519

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10519

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10519

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10519

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10519

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10519

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10519

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10519

commit: adb318c

austincalvelage · 2026-10-29T15:36:49Z

closing in favor of #10518

fix(mosaic): localize passkey cancellation and failure errors

adb318c

github-actions Bot added the mosaic label Oct 29, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 29, 2026 02:02

View deployment

vercel Bot deployed to Preview – swingset October 29, 2026 02:05

View deployment

coderabbitai Bot mentioned this pull request Oct 29, 2026

fix(mosaic): show localized errors in reverification instead of raw error text #10518

Merged

2 of 9 tasks

austincalvelage closed this Oct 29, 2026

Navigation Menu

Repository navigation

fix(mosaic): localize passkey cancellation and failure errors - #10519

fix(mosaic): localize passkey cancellation and failure errors#10519
austincalvelage wants to merge 1 commit into
mainfrom
austin/passkey-cancellation-error

austincalvelage commented Oct 29, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 29, 2026

Uh oh!

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 29, 2026

Uh oh!

austincalvelage commented Oct 29, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

austincalvelage commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercel Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 29, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 29, 2026

Uh oh!

austincalvelage commented Oct 29, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

austincalvelage commented Oct 29, 2026 •

edited

Loading

vercel Bot commented Oct 29, 2026 •

edited

Loading

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading