Repository navigation
feat(mosaic): render self-contained sections in user profile panels - #10187
Conversation
🦋 Changeset detectedLatest commit: 0f8924b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
99cf9fa to
857a8dd
Compare
857a8dd to
a029fca
Compare
a029fca to
00dec4c
Compare
Ephem
left a comment
There was a problem hiding this comment.
This is really nice, love to see it coming together!
| import type { UserProfilePasskey } from './user-profile-passkeys-section.view'; | ||
|
|
||
| export type { UserProfileDevice, UserProfileMfaAddableMethod, UserProfileMfaMethod, UserProfilePasskey }; |
There was a problem hiding this comment.
NIT: 🤖 thinks some/all of these type import/reexports can be removed now.
00dec4c to
8f9afcc
Compare
8f9afcc to
0f8924b
Compare
Description
User profile panels now work like the legacy ones: each section is a self-contained connected component that renders its own card and hides itself when it does not apply, and the panels render a title plus
children.UserProfileProfilePanel. Without children it renders the profile, email, phone, connected accounts, enterprise accounts, Web3 wallets and danger sections.UserProfileSecurityPaneltakeschildren. Without them it renders the password, passkeys, 2-step verification and active devices sections.UserProfileProfilePanelViewandUserProfileSecurityPanelViewtakechildrenin place of the*Slotprops. The security view no longer takes the MFA props, and the Authentication group card is gone.Section.Rootcard.UserProfileSecurityPanelno longer takespasswordFallback. Passfallbackto the section instead.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change