fix(analytics): eliminate duplicate market_chart call in volume action#51
Open
ddfp777 wants to merge 1 commit into
Open
fix(analytics): eliminate duplicate market_chart call in volume action#51ddfp777 wants to merge 1 commit into
ddfp777 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50.
_fetch_prices now returns all three series from the single CoinGecko market_chart response; _handle_volume consumes the shared data instead of refetching. Implements the fix the existing docstring proposed.
Zero behavior change: volumes are passed raw and _handle_volume keeps its two-stage validation verbatim, so all error codes and output formats are identical. One test rewritten (test_volume_api_error simulated the second call failing, which no longer exists); all other tests pass unchanged. Full suite green. (Full-suite run shows pre-existing Windows-environment failures — chmod semantics, pytest-asyncio config — verified identical on unmodified main.)
Patch written by Zero (gitlawb) from a spec authored by my Hermes agent, which found the issue auditing its own toolkit. Human-verified before submission.