fix(venice): classify insufficient-balance 402 as payment_required (v0.18.1) - #44
Merged
Merged
Conversation
…(v0.18.1)
Venice returns HTTP 402 for two different conditions: a missing/invalid key
("Authentication required") and a valid key on an account with no funds
("Insufficient USD or Diem balance"). Both were classified as no_credentials;
the balance case now raises payment_required so callers know to add credits
(venice.ai/settings/api) rather than fix auth. Found while live-testing a real
Venice key — the key authenticated fine, the account was just empty.
Gate: full suite green, 100% coverage; ruff clean; plugin.yaml byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Venice returns HTTP 402 for two distinct conditions:
v0.18.0 classified both as
no_credentials. This splits the balance case into a newpayment_requiredcode so the failure is actionable (top up vs fix auth).Surfaced while live-testing a real Venice key: the key authenticated fine — the account just had no credits. Adds a unit test for the new branch; full suite green at 100% coverage; plugin.yaml byte-identical.