Skip to content

update dev dependencies - #9

Open
borracciaBlu wants to merge 1 commit into
cjpatoilo:mainfrom
borracciaBlu:fix/update-dependnecies
Open

update dev dependencies#9
borracciaBlu wants to merge 1 commit into
cjpatoilo:mainfrom
borracciaBlu:fix/update-dependnecies

Conversation

@borracciaBlu

Copy link
Copy Markdown

No description provided.

@borracciaBlu

borracciaBlu commented Dec 17, 2019

Copy link
Copy Markdown
Author

on npm audit:

found 9 vulnerabilities (2 low, 2 moderate, 4 high, 1 critical)

these apparently are related to marshmallow and inject-ga.

I see that these two package are not strictly related to the package and are used only on deploy:

"deploy": "marshmallow -o docs -i artwork.psd -f -m && inject-ga docs/index.html -o docs/index.html -c 'UA-24389952-13' && boeing docs && rimraf docs",

If i may, i would suggest to remove the two packages and in deploy use instead npx:

"deploy": "npx marshmallow -o docs -i artwork.psd -f -m && npx inject-ga docs/index.html -o docs/index.html -c 'UA-24389952-13' && npx boeing docs && rimraf docs",

@borracciaBlu

Copy link
Copy Markdown
Author

In here i got a working prototype
borracciaBlu/banner-cli@aed3ea8

additional benefit of npx you don't have to keep update these packages all the times because npx is going to use the latest version

@github-staff github-staff deleted a comment from apocanow1 Apr 11, 2024
@github-staff github-staff deleted a comment from sandeep661 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant