Repository navigation
fix(eks): apply Karpenter node class updates in place - #817
Merged
Merged
Conversation
Contributor
OPA/conftest tenant-isolation gateResult: passed
|
Contributor
Offline IaC contract testsResult: passed
Coverage: 95.27% (1509/1584 lines) Lowest-covered Lambda files
|
Contributor
Mutation test critical Lambda boundariesResult: passed
Coverage: 39.67% (1215/3063 lines) Lowest-covered Lambda files
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Automation gate testsResult: passed
Coverage: 88.30% (906/1026 lines) Lowest-covered Lambda files
|
Contributor
Lambda unit testsResult: passed
Coverage: 92.76% (4641/5003 lines) Lowest-covered Lambda files
|
Contributor
OpenTofu module tests (latest-stable)Result: passed OpenTofu version:
|
Nikolaichukr
force-pushed
the
fix/karpenter-nodeclass-in-place
branch
from
November 2, 2026 22:24
0289351 to
a7c2d58
Compare
Contributor
OpenTofu module tests (minimum-supported)Result: passed OpenTofu version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An AMI update can stall an EKS apply because the provisioner deletes the Karpenter
EC2NodeClassbefore applying its replacement.The current sequence clears the class's finalizers, deletes it, and recreates it. Karpenter can restore its termination finalizer between the first two steps. When existing
NodeClaimsstill reference the class, deletion remains pending and the replacement manifest is never applied.Update the class in place with
kubectl apply. Mutable changes such as the AMI selector no longer require deleting the class or interfering with Karpenter's finalizers. Karpenter can reconcile the updated configuration through its normal node lifecycle.The provisioner also:
Regression tests execute the provisioner with a fake kubectl and verify that it issues a single apply operation, preserves literal manifest values, and propagates command failures. All 18 focused IaC tests, the OpenTofu formatting check, and the diff checks passed.