fix(examples): harden empty wallet accounts on connect - #8
Closed
kutluhaneth46 wants to merge 1 commit into
Closed
kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
kutluhaneth46
force-pushed
the
fix/harden-empty-wallet-accounts
branch
from
September 6, 2026 14:16
81dc7aa to
e2106c6
Compare
Contributor
hjchen-circle
added a commit
to hjchen-circle/docs-examples
that referenced
this pull request
Sep 16, 2026
This PR: - addresses the issue raised in circlefin#6 and supersedes circlefin#7 and circlefin#8 - also clears the output panel on successful wallet connect - surfaces the actual `Error` throw message instead of generic `Unknown error` - adds potential troubleshooting guidance for Swap kit in case of bad RPC - switches out Base Sepolia for Avalanche Fuji for the unified balance kit demo and explains the situation of both EVM and Solana wallet prompts required during the spend operation - drops the estimate pre-step for `send()` and `swap()` - bumps dependencies to latest versions Closes circlefin#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_requestAccounts, fall back toeth_accounts, and throw when no account is available so the catch path keeps action buttons disabledapp-kit-bridge-solanaComplementary to #6 / #7 (retry-after-rejection). This PR targets the empty-account / false-connected path rather than permission rejection alone.
Test plan
cd app-kit-send && npm install && npm testcd app-kit-swap && npm install && npm testcd app-kit-bridge-evm && npm install && npm testcd app-kit-bridge-solana && npm install && npm test