Skip to content

Limit compatibility-note retirement to fork preview release tags #149

Open

Description

@chrisohearn

A nonblocking P3 from the independent exact-head review of PR #147 at f8ea210.

scripts/fork/publish-release.sh selects the previous release with git tag --list 'v*-preview.*' --merged "$target". That pattern can include upstream preview tags as well as fork preview tags. If an upstream preview tag sorts above the latest fork release and its publisher lacks CODEX_SHADOW_COMPATIBILITY_RELEASE_NOTE_V1, a later fork release could append the compatibility paragraph again.

Follow up by selecting only fork preview tags (or otherwise proving the marker check uses the latest fork publisher) and add a fixture with a newer reachable upstream preview tag. The current mirror's fork tags sort above the upstream preview tag noted in review, so this only affects a future history where that ordering changes. It does not block merging PR #147.

Source review: PR #147, head f8ea21009dc5247c6dd05bca4e02e41d4310d2f3.

Activity

  1. chrisohearn commented on Nov 20, 2026

    @chrisohearn
    OwnerAuthor

    The upstream sync could not merge pingdotgg/t3code upstream v0.1.11 (59651c1) (59651c1, 643 commits) into integration/mcp-events-20261109.

    Conflicting files:

    • apps/desktop/src/app/DesktopApp.test.ts
    • apps/server/src/auth/EnvironmentAuth.test.ts
    • apps/server/src/cloud/servicePreflight.ts
    • apps/server/src/mcp/McpHttpServer.test.ts
    • apps/server/src/mcp/McpHttpServer.ts
    • apps/server/src/mcp/McpInvocationContext.ts
    • apps/server/src/mcp/OrchestratorMcpService.test.ts
    • apps/server/src/mcp/OrchestratorMcpService.ts
    • apps/server/src/mcp/toolkits/core.test.ts
    • apps/server/src/mcp/toolkits/project/handlers.ts
    • apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts
    • apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts
    • apps/server/src/orchestration-v2/EffectOutbox.ts
    • apps/server/src/orchestration-v2/EventSink.ts
    • apps/server/src/orchestration-v2/Orchestrator.ts
    • apps/server/src/orchestration-v2/ProjectionStore.ts
    • apps/server/src/orchestration-v2/ProviderTurnControlService.test.ts
    • apps/server/src/orchestration-v2/ProviderTurnStartService.test.ts
    • apps/server/src/orchestration-v2/ProviderTurnStartService.ts
    • apps/server/src/orchestration-v2/RunExecutionService.test.ts
    • apps/server/src/orchestration-v2/testkit/ProviderSwitch.integration.test.ts
    • apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts
    • apps/server/src/scheduledTasks/ScheduledTaskService.test.ts
    • apps/server/src/scheduledTasks/ScheduledTaskService.ts
    • apps/server/src/textGeneration/ClaudeTextGeneration.ts
    • apps/server/src/textGeneration/CodexTextGeneration.ts
    • apps/web/src/components/chat/ProviderStatusBanner.tsx
    • apps/web/src/components/settings/ProjectDefaultsSettings.tsx
    • apps/web/src/components/settings/ScheduledTasksSettings.tsx
    • evals/shared/proxy.ts
    • packages/shared/src/htmlRender.ts
    • pnpm-lock.yaml

    Resolve it in a worktree from fresh origin/integration/mcp-events-20261109, following FORK.md (fork migrations stay in ForkMigrations/), then open a PR into integration/mcp-events-20261109 from a sync/upstream-* branch. The next sync run checks, merges and releases it.

  2. changed the title [-]Limit compatibility-note retirement to fork preview release tags[/-] [+]Upstream sync conflict: upstream v0.1.11 (59651c1761)[/+] on Nov 20, 2026
  3. changed the title [-]Upstream sync conflict: upstream v0.1.11 (59651c1761)[/-] [+]Limit compatibility-note retirement to fork preview release tags[/+] on Nov 20, 2026
  4. chrisohearn commented on Nov 20, 2026

    @chrisohearn
    OwnerAuthor

    Correction: the upstream v0.1.11 conflict report was posted here by mistake because the sync script selected the newest open issue with the upstream-sync label. This issue's original P3 finding and title are restored. The conflict is tracked separately at #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions