[Capability] Suppress list-changed events during the initial registry load - #35
Closed
chr-hertel wants to merge 3 commits into
Closed
chr-hertel wants to merge 3 commits into
chr-hertel wants to merge 3 commits into
Conversation
Owner
Author
|
Merged upstream with modelcontextprotocol#480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry dispatched a list-changed event per element while the deferred loader ran, publishing spurious frames onto a configured notification bus before any client had observed a list. Registrations are now routed through a helper that skips dispatch while
loadingis set — the load establishes the initial state before the first read returns, so no change is observable and no end-of-load event is needed.Closes #26
Confidence: 9/10 — minimal guarded dispatch using the existing loading flag, covered by suppression and runtime-dispatch regression tests; full unit suite, cs-fixer, and phpstan pass.