[Schema] Fix _meta guard key in Request::jsonSerialize() - #34
Closed
chr-hertel wants to merge 2 commits into
Closed
chr-hertel wants to merge 2 commits into
chr-hertel wants to merge 2 commits into
Conversation
…xtprotocol#483) Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 9.0.0 to 10.0.1. - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@v9.0.0...v10.0.1) --- updated-dependencies: - dependency-name: astral-sh/setup-uv dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chr-hertel
force-pushed
the
fix/issue-30-jsonserialize-guard
branch
from
August 29, 2026 08:30
2c1f67a to
ca8517e
Compare
Owner
Author
|
Closed upstream by modelcontextprotocol#485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard checked $params['meta'] while the write targets $params['_meta'], so params-provided _meta could be silently overwritten. Fix the key and add a regression test. Also fixes the identical guard in Notification::jsonSerialize() with a mirror test.
Closes #30
Confidence: 10/10 — one-character key fix matching the audit finding exactly; full unit suite, cs-fixer, and phpstan pass.