Repository navigation
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure#949 added grouped participant admission and the fail-closed Workflow contract, but intentionally left backend execution to operators. This follow-up adds an upstream generic adapter that now runs one independently pinned Pod or MPIJob per participant, records API-assigned backend identities, aggregates typed results, and cleans up every created resource while preserving
Inconclusiveat infrastructure boundaries.project-signal-adapter, a Go executable that validates the ordered participant snapshot, immutable script/image inputs, queue and lifecycle policy, and the 64-participant bound.kubeflow.org/v2beta1MPIJob per participant for MPI diagnostics. Each MPIJob has one zero-GPU launcher and one Node-pinned GPU worker, with a configurable Kueue queue label, Workflow deadline, backoff, TTL,cleanPodPolicy: All, and replica-levelrestartPolicy: Never.Pass. Backend execution failure takes precedence over diagnostic failure and remainsInconclusive.project-signal-participant-adapterWorkflowTemplate, namespace-scoped ServiceAccount/RBAC, adapter container build, manifest wiring, and operator documentation.Scope boundary
No certification scripts, runner packaging, hardware thresholds, deployment overlays, queue or flavor values, tolerations, cluster or node identifiers, credentials, endpoints, or live-resource actions are included. The adapter supports the existing Pod and MPIJob contract only; other backends remain operator-supplied.
Evidence
The attached 15-second recording shows the exact Workflow contract, MPIJob lifecycle/topology policy, and the focused rendering, fail-closed aggregation, and cleanup tests.
Verification
go test -race ./api/signal/v1alpha1 ./internal/signal ./internal/signaladapter ./cmd/project-signal-controller ./cmd/project-signal-adapter ./deploy/signalgolangci-lint run ./api/signal/v1alpha1 ./internal/signal ./internal/signaladapter ./cmd/project-signal-controller ./cmd/project-signal-adapter ./deploy/signalmake signal-manifestsgo build ./cmd/project-signal-controller ./cmd/project-signal-adaptergit diff --checkRisk
The main risk is compatibility with MPI Operator Pod labeling and cleanup timing. The adapter matches launcher Pods by the created MPIJob UID plus the launcher container name, samples results while execution is active, and fails closed if identity, status, logs, outputs, or cleanup cannot be proven. Rollback is this single commit and the two optional adapter manifests.
Review guide
internal/signaladapter/adapter.gofor participant validation, Pod/MPIJob rendering, output bounds, and aggregation precedence.internal/signaladapter/runner.gofor concurrent observation, API-assigned identity collection, result capture, and foreground cleanup.deploy/signal/04-adapter-workflowtemplate.yaml.tmpland03-adapter-serviceaccount-rbac.yaml.tmplfor the feat(signal): add grouped certification controller Azure/unbounded#949 invocation path and permission boundary.internal/signaladapter/*_test.goanddeploy/signal/manifest_test.gofor malformed identities, partial failures, bounds, lifecycle policy, and cleanup coverage.project-signal-adapter.mp4