Repository navigation
release: do not build the x86_64 test port - #7
Merged
Merged
Conversation
The release matrix took every src/port/*/port.c, including x86_64 - the software-loopback stand-in CI uses to run test_dmspi, which is never published. A full build for it fetches dmgpio headers for x86_64, which dmgpio does not publish, so the v0.1 release failed. CI already builds only dmspi_port for x86_64; the release now skips it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TgkwHQKqf6c4DzypSKzZT7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failed v0.1 release (run 36579012755, job "Build dmspi for x86_64":
dmgpio_types.h: No such file or directory).Cause
The release matrix builds every family that has a
src/port/*/port.c. Since f869762 that includesx86_64, the software-loopback port that CI uses to runtest_dmspi. That port is never published.A full build with
DMOD_CPU_FAMILY=x86_64fetches the dmgpio headers for x86_64, and dmgpio only publishes stm32f4/stm32f7 packages.ci.ymlalready works around this by building onlydmspi_portfor x86_64 (see the comment there).release.ymlhad no such exception, and v0.1 is the first dmspi release, so this is the first time it failed.Fix
The family discovery in
release.ymlskipsx86_64. The matrix is now["stm32f4","stm32f7"], and those builds are the same as the CI family jobs that pass onmain.After merging
The v0.1 release has no assets. Either delete the v0.1 release and tag and create it again, or create v0.1.1. Either way, the release has to be created after this is merged, because the release workflow runs from the tagged commit.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TgkwHQKqf6c4DzypSKzZT7
Generated by Claude Code