Skip to content

ymodem_send: report the files the device did not write #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaxCalder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ymodem_send: report the files the device did not write #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/ymodem_send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,14 @@ def progress(name, sent, size):
said = link.drain(0.5).decode(errors='replace').strip()
log(f'{len(files)} file(s), {total} bytes in {seconds:.1f} s ({total / seconds / 1024:.1f} KiB/s)'
+ (f', {link.retries} block(s) sent again' if link.retries else ''))
if said:
log(f'device: {said.splitlines()[0] if said.startswith("ymodem") else said}')
answer = next((l.strip() for l in said.splitlines() if l.strip().startswith('ymodem:')), said)
if answer:
log(f'device: {answer}')
if 'not written' in answer:
# (files the device had open - played, shown: received, left as they were)
print(f'ymodem_send: some files were not written - in use on the device? Stop what uses them '
f'(e.g. `service stop carhmi`) and send them again: {answer.split(": ", 2)[-1]}', file=sys.stderr)
return 1
return 0
except Failure as e:
try:
Expand Down
Loading