Repository navigation
Fix environment iteration used by dmell export - #9
Merged
Merged
Conversation
JohnAmadis
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dmellsaves variables throughDmod_SetEnv, whichdmenvimplements using its current context. Bareexportlists names throughDmod_GetNextEnvName, butdmenvdid not implement that API. The fallback iterator reads the host environment (or returns no names on embedded targets), so exported variables are missing.Change
Implement
Dmod_GetNextEnvNameindmenvusing the same current context asDmod_GetEnvandDmod_SetEnv. Include inherited variables and omit names shadowed by a child context. Add regression tests for the export path and inheritance.Verification
ctest --test-dir /tmp/dmenv-export-build -R '^test_dmenv_unit$' --output-on-failure— 27 tests passed.