Repository navigation
Conversation
Use a dmlist_context_t in directory_node_t to track already-emitted directory names across the entire readdir traversal, not just consecutive entries. Previously file entries between same-parent drivers would break the dedup loop and produce duplicate directory entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
readdiremitting duplicate directory entries when file entries appear between drivers sharing the same parent directory.Root cause: The original dedup loop in
_readdironly skipped consecutive directory entries. File entries between same-parent drivers broke the loop and caused duplicates.Fix: Use a
dmlist_context_tindirectory_node_tto track already-emitted directory names across the entire readdir traversal, not just consecutive entries.Files changed:
src/dmdevfs.c: Core dedup fix indirectory_node_t,_opendir,_readdir, and_closedirtests/fixtures/config/readdir_dedup.ini: New fixture exercising the non-consecutive duplicate scenario