Repository navigation
Scan partitions only on nodes reported as block devices - #64
Merged
Merged
Conversation
scan_partitions() opened every node that became available - tty, gpio, dma streams, ... - to ask DMDRVI_IOCTL_BLOCK_GET_INFO, right after report_node_added() had already opened it to ask the very same question. Every node was therefore opened twice, report= was ignored (a node with report=none was still opened for its partition table), and drivers that open exclusively failed loudly: on stm32f746g-disco each probe of /dmdma1/3, the DMA2 stream leased by dmsdio, logged "dmdma: stream 3 already open". scan_partitions() now only reads the table of a node that report_node_added() reported as "block". A node whose report= excludes block gets no partition nodes and is not opened for them. The test driver counts the opens of its host node and child, and a new step checks that a plain node is opened once and a report=none node and its child not at all. This supersedes the report_mask check #65 added to scan_partitions(): report_node_added() only ever records classes the report= mask allows, so a node it reported as block always passes that check too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JohnAmadis
force-pushed
the
fix/probe-nodes-once
branch
from
October 1, 2026 06:14
64919e5 to
431f487
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan_partitions() opened every node that became available - tty, gpio, dma streams, ... - to ask DMDRVI_IOCTL_BLOCK_GET_INFO, right after report_node_added() had already opened it to ask the very same question. Every node was therefore opened twice, report= was ignored (a node with report=none was still opened for its partition table), and drivers that open exclusively failed loudly: on stm32f746g-disco each probe of /dmdma1/3, the DMA2 stream leased by dmsdio, logged "dmdma: stream 3 already open".
scan_partitions() now only reads the table of a node that report_node_added() reported as "block". A node whose report= excludes block gets no partition nodes and is not opened for them.
The test driver counts the opens of its host node and child, and a new step checks that a plain node is opened once and a report=none node and its child not at all.