Repository navigation
Match dmfsi's API versions for _readdir and _size - #63
Merged
Merged
Conversation
dmfsi bumped _readdir to 2.0 when dmfsi_dir_entry_t.size became
dmfsi_size_t (u64), but dmdevfs kept exporting _readdir@dmfsi:1.0. dmvfs
looks the function up by the 2.0 signature, finds nothing, and fails
every directory listing under /dev ("API version mismatch: 1.0/1.0 !=
2.0/1.0", "File system does not support readdir") - so `ls /dev` and
Tab completion of /dev paths were broken. The implementation was already
built against the new dmfsi_dir_entry_t, only the signature was stale.
_size went the other way: dmdevfs exported 2.0 while dmfsi (and dmffs,
dmramfs) declare it 1.0, so any lookup by dmfsi's signature would miss
dmdevfs as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmfsi bumped _readdir to 2.0 when dmfsi_dir_entry_t.size became dmfsi_size_t (u64), but dmdevfs kept exporting _readdir@dmfsi:1.0. dmvfs looks the function up by the 2.0 signature, finds nothing, and fails every directory listing under /dev ("API version mismatch: 1.0/1.0 != 2.0/1.0", "File system does not support readdir") - so
ls /devand Tab completion of /dev paths were broken. The implementation was already built against the new dmfsi_dir_entry_t, only the signature was stale._size went the other way: dmdevfs exported 2.0 while dmfsi (and dmffs, dmramfs) declare it 1.0, so any lookup by dmfsi's signature would miss dmdevfs as well.