feat(slug): generate group/stage/festival slugs in DB by chiptus · Pull Request #518 · chiptus/UpLine

chiptus · 2026-10-05T05:21:46Z

UPL-54: adds BEFORE INSERT slug triggers for groups, stages, festivals and festival_editions (same idea as sets/artists) and stops the group/stage create hooks from computing slugs client-side.
Derived slugs get -2, -3, … within each table's unique scope; an explicit slug (admin festival dialogs) is kept as-is and still errors on conflict. The festival dialogs still auto-fill their visible slug field in the UI, so that path sends an explicit slug.

Verification

Create a group and a stage in the app; each gets a slug derived from its name.
Create a second group with the same name as your first group; its slug ends in -2.
Create a group/stage named in a non-Latin script (e.g. כנסיית השכל); it gets a non-empty n-xxxxxxxx slug.
Create a festival/edition via the admin dialog with a custom slug; it is kept, and reusing a taken slug keeps the dialog open with an error.
pnpm run test:integration -- slugTriggers against local Supabase passes.

Note: this adds a migration, so the PR needs the staging label (maintainer-applied) to pass the migration gate.

🤖 Generated with Claude Code

https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

UPL-54: extend the BEFORE INSERT dedupe triggers to groups, stages, festivals and festival_editions and stop sending client-computed slugs from the group and stage create paths. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

vercel · 2026-10-05T05:21:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
upline	Ready	Preview	Oct 5, 2026 6:00am UTC

chiptus · 2026-10-05T05:22:08Z

"Require staging label for migrations" is red because this PR adds a migration and has no staging label. That is the gate working as intended, not a code failure. The staging label is off-limits to the autonomic worker, so it needs the maintainer to apply it. That should also let the migrate and integration jobs run. I'm not pushing anything for it.

Generated by Claude Code

github-actions · 2026-10-05T05:22:09Z

Deploy → staging — workflow run
Last updated: 2026-10-05 08:55:47 UTC

✅ DB migrations succeeded
⏭️ Edge functions skipped (no changes)
⏭️ Type generation skipped (no changes)

Copilot

Copilot review overview

🟡 Changes recommended

Slug allocation can race across overlapping bases, and an existing edition-dialog test contradicts the new behavior.

Review effort: Balanced
Findings: 2

Open (2)

Slug allocation locks allow concurrent collisions across base slugs · New
Update edition slug integration test for automatic suffixing · New

What changed in this PR

Extends database-managed slug generation to groups, stages, festivals, and editions, following the existing artist/set pattern.

Changes:

Adds scoped slug deduplication triggers.
Delegates group and stage slug creation to the database.
Adds integration coverage for generated slugs, collisions, and explicit values.

File	Description
`supabase/migrations/20261005050700_add_remaining_slug_dedupe_triggers.sql`	Adds four slug-generation triggers.
`src/test/integration/slugTriggers.integration.test.ts`	Tests slug generation and uniqueness scopes.
`src/api/stages/useCreateStage.ts`	Requests database-generated stage slugs.
`src/api/groups/useCreateGroup.ts`	Requests database-generated group slugs.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-10-05T05:27:38Z

Playwright test results

68 passed

Details

68 tests across 22 suites
1 minute, 33 seconds
68e7795

Copilot review on #518: different bases can resolve to the same final slug, so the advisory lock is now keyed on the uniqueness scope. Explicit slugs are no longer suffixed, so a taken one still surfaces as a conflict in the admin dialogs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

Copilot

Copilot review overview

🟡 Changes recommended

Explicit-slug inserts bypass allocation locks, allowing concurrent derived inserts to fail instead of receiving suffixes.

Review effort: Balanced
Findings: 1

Open (1)

Acquire scope locks before explicit slug early returns · New

Resolved since last review (2)

Update edition slug integration test for automatic suffixing
Slug allocation locks allow concurrent collisions across base slugs

Copilot review on #518: an uncommitted explicit insert (e.g. commit_schedule) must serialize with concurrent derived inserts, or the derived one picks the same slug and hits the unique constraint. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

Copilot

Copilot review overview

🟢 Approval recommended

The changes preserve uniqueness scopes and explicit-slug conflicts, with no unresolved blocking issues identified.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Acquire scope locks before explicit slug early returns

Copilot AI balanced review requested due to automatic review settings October 5, 2026 05:21

vercel Bot deployed to Preview October 5, 2026 05:22 View deployment

Copilot started reviewing on behalf of chiptus October 5, 2026 05:22 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread supabase/migrations/20261005050700_add_remaining_slug_dedupe_triggers.sql Outdated

Comment thread supabase/migrations/20261005050700_add_remaining_slug_dedupe_triggers.sql

vercel Bot deployed to Preview October 5, 2026 05:29 View deployment

docs(agents): require convention branch names in the fix firing

d78ce06

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

vercel Bot deployed to Preview October 5, 2026 05:42 View deployment

docs(git): generate convention branch names, never claude/...

f0259db

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

vercel Bot deployed to Preview October 5, 2026 05:45 View deployment

docs(claude): generate convention branch names, not claude/...

678bdd6

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fa8de7wuEMyUbpJgwn1Uv

vercel Bot deployed to Preview October 5, 2026 05:46 View deployment

chiptus commented Oct 5, 2026

View reviewed changes

Comment thread src/api/groups/useCreateGroup.ts

Comment thread src/test/integration/slugTriggers.integration.test.ts

chiptus requested a balanced review from Copilot October 5, 2026 05:51

Copilot started reviewing on behalf of chiptus October 5, 2026 05:52 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread supabase/migrations/20261005050700_add_remaining_slug_dedupe_triggers.sql

vercel Bot deployed to Preview October 5, 2026 06:00 View deployment

chiptus requested a balanced review from Copilot October 5, 2026 06:12

Copilot started reviewing on behalf of chiptus October 5, 2026 06:12 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

chiptus added the staging label Oct 5, 2026

chiptus deployed to staging October 5, 2026 08:54 — with GitHub Actions Active

Navigation Menu

Repository navigation

feat(slug): generate group/stage/festival slugs in DB - #518

feat(slug): generate group/stage/festival slugs in DB#518
chiptus wants to merge 6 commits into
mainfrom
claude/relaxed-wright-3berdm

chiptus commented Oct 5, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

chiptus commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chiptus commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification

Uh oh!

vercel Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chiptus commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright test results

Details

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chiptus commented Oct 5, 2026 •

edited

Loading

vercel Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading