Skip to content

chore(lint): harden mikey-pro gate for missing tooling - #944

Closed
chiefmikey wants to merge 1 commit into
mainfrom
chore/mikey-pro-gate-hardening
Closed

chiefmikey wants to merge 1 commit into
mainfrom
chore/mikey-pro-gate-hardening

Conversation

@chiefmikey

Copy link
Copy Markdown
Owner

Summary

  • The merged gate failed commits in a checkout without node_modules (prettier could not resolve its config). The pre-commit hook now warns and continues when the toolchain is not installed. Formatting stays blocking when installed; eslint/stylelint stay advisory.
  • mikey-pro added as a direct devDependency and the svelte config bumped 10.1.0 -> 10.3.4: 10.1.0 crashed eslint 10 on whole-tree runs (hidden by the advisory wrapper). Full lint now runs (1035 errors, hence advisory).

Test Plan

  • Unparsable staged file: commit blocked (SyntaxError, exit 1)
  • Misformatted staged file: auto-formatted and committed
  • Clone without node_modules: commit succeeds with a warning
  • vitest 249 passed; webpack prod build OK

- pre-commit warns and continues when node_modules is absent (fresh
  clone/worktree) instead of failing on a missing prettier/mikey-pro
- add mikey-pro as a direct devDependency and bump the svelte config to
  10.3.4 (10.1.0 crashed eslint 10 on whole-tree runs; the advisory wrapper
  was hiding it)

Formatting stays blocking when installed; eslint/stylelint stay advisory.
@chiefmikey

Copy link
Copy Markdown
Owner Author

Superseded by the mikey-pro v2 never-block migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant