Repository navigation
ci: pin the release toolkit to v4.1.0 - #221
Merged
Merged
Conversation
v4.1.0 installs the toolkit under its own pnpm (10.34.7) and its own settings, so the caller's pnpm-workspace.yaml (pnpm 12, the 7-day release-age and trust policy) no longer applies to the toolkit's lockfile during release jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the three release caller stubs to obsidian-plugin-workflows
v4.1.0(149e378), up fromv4(ebcf84b).Why. Since #219, the release jobs ran the toolkit install (
pnpm --dir .release-toolkit install --frozen-lockfile) inside this repo. That install picked up our rootpnpm-workspace.yaml. It switched to our pnpm 12.14.0 and applied our 7-day release-age and trust policy to the toolkit's own lockfile. It passed, but a toolkit lockfile carrying any package younger than 7 days would have failed a release. v4.1.0 installs the toolkit under its own pnpm 10.34.7 and its own settings, with a regression test upstream.What changes. Only the
uses:SHA and version comment inrelease-prepare.yml,release-trigger.ymlandrelease.yml. No input, secret or permission changes. There are no other references to the toolkit in.github/.Verification. After merge, Prepare release is dispatched with
dry-run: trueon master. The run's log should show the toolkit install running under pnpm 10.34.7 and installing the toolkit's own dependencies.Note
Low Risk
CI-only pin bump with no runtime or application code changes; reduces risk of release workflow failures from workspace pnpm policy bleed-through.
Overview
Bumps all three release pipeline caller workflows (
release-prepare.yml,release-trigger.yml,release.yml) from obsidian-plugin-workflows v4 to v4.1.0 by updating the pinneduses:commit SHA and version comment only—no workflow inputs, secrets, or permissions change.v4.1.0 addresses a failure mode where toolkit install ran under this repo’s pnpm workspace (e.g. 7-day release-age policy on lockfile packages). The new toolkit version installs with its own pnpm and settings so release jobs are not blocked by root workspace policy on the toolkit’s dependencies.
Reviewed by Cursor Bugbot for commit 430f097. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Pin release toolkit reusable workflow to v4.1.0
Updates the reusable release-prepare workflow reference in release-prepare.yml from the commit pinned as v4 to commit
149e378labeled v4.1.0. No inputs, permissions, conditions, or secrets changed.Macroscope summarized 430f097.