Autocrypt 2#8318
Draft
link2xt wants to merge 4 commits into
Draft
Conversation
link2xt
force-pushed
the
link2xt/autocrypt2
branch
from
d613423 to
f08a85f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8317
Closes #6520 (key selection is now based on Autocrypt 2 spec, we select not expired subkey with the closest expiration date and also make sure it is marked with a flag that says the key can be used to encrypt communications).
Closes #8224. For Autocrypt 2 keys we set creation timestamp of the primary key and fallback subkey to 0. These timestamps cannot be changed. Direct key signature we already recreate before deriving the public key, and fallback subkey signature we can also recreate each time. For rotating subkey there is no problem as it will be recreated each 10 days. Autocrypt 1 key generation is not changed, we will likely want to remove it eventually anyway once Autocrypt 2 key generation is enabled.
There is a reference Rust implementation in https://codeberg.org/autocrypt2/autocrypt-v2-cert/ as well, we want to keep it in sync but i'm not using it directly as we don't need deterministic key generation, have different error handling, need to set timestamps to 0, and there going to still be changes to the specification. It would be great to merge the codebases and turn this into a single implementation properly published as a crate.