chore: use frozen lockfile for CI dependency installs - #223
Merged
Conversation
Replace bare `yarn install` with `yarn install --frozen-lockfile` in the build and release workflows so CI installs exactly what the committed yarn.lock specifies. Also key the node_modules cache off yarn.lock instead of package-lock.json. The install step is guarded by a cache-hit check, and the old key hashed a lockfile that yarn never writes to, so dependency changes did not invalidate the cache and the install step was skipped. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe build and release workflows now use ChangesCI dependency lockfile handling
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
GitHub auto-fails jobs using actions/cache@v2, so the build job aborted during setup before reaching the install step. release.yml already uses v4; this brings build.yml in line so the frozen-lockfile install is actually exercised. Co-authored-by: Cursor <cursoragent@cursor.com>
cb-kedarborkar
approved these changes
Aug 5, 2026
cb-haripriyan
approved these changes
Aug 5, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
chore: use frozen lockfile for CI dependency installs
SUMMARY
Closes the 2 supply-chain security findings raised against this repo (deadline: August 9, 2026).
Both findings are bare
yarn installsteps in GitHub Actions, which resolve dependencies fresh instead of installing exactly what the committed lockfile specifies:.github/workflows/build.yml.github/workflows/release.ymlBoth are now
yarn install --frozen-lockfile. The repo pins"packageManager": "yarn@1.22.19", so this is the deterministic equivalent for yarn v1 — it fails the build rather than silently rewriting the lockfile ifyarn.lockhas drifted frompackage.json.No lockfile needed to be added:
yarn.lockis already committed and tracked.Also included: cache key fix
Both workflows keyed the
node_modulescache offhashFiles('**/package-lock.json')while installing with yarn. Since the install step is guarded byif: steps.cache-nodemodules.outputs.cache-hit != 'true', and the stalepackage-lock.jsonnever changes, dependency updates did not invalidate the cache and the install step was being skipped entirely — builds ran against whatevernode_moduleswas cached earlier. Both keys now hashyarn.lock, so--frozen-lockfileactually runs when dependencies change.Also included:
actions/cache@v2→v4in build.ymlThe
buildcheck has been failing on every PR since at least June 2026 (including Snyk's automated ones), and it was failing on this PR too. The cause is unrelated to the changes above:The job aborted during setup, before reaching the install step.
release.ymlwas already onactions/cache@v4; onlybuild.ymlwas left behind. Bumping it was necessary to get any verification of the frozen-lockfile change at all.FUNCTIONAL AUTOMATION CHANGES PR
AUTOMATION TEST REPORT URL
NA — the existing lint and test steps in
build.ymlare the verification.AREAS OF IMPACT
CI only (
.github/workflows/build.yml,.github/workflows/release.yml). No changes to published package contents or runtime behaviour.TYPE OF CHANGE
DOCUMENTATION
Supply-chain security initiative announcement in #team-engineering. Questions to #ask-security.