fix(crafter): surface DNS-1123 validation errors instead of masking them#2983
Open
waveywaves wants to merge 1 commit intochainloop-dev:mainfrom
Open
fix(crafter): surface DNS-1123 validation errors instead of masking them#2983waveywaves wants to merge 1 commit intochainloop-dev:mainfrom
waveywaves wants to merge 1 commit intochainloop-dev:mainfrom
Conversation
waveywaves
force-pushed
the
fix/dns1123-error-masking
branch
from
9241f71 to
2c1b24b
Compare
Member
|
@waveywaves is this ready to be reviewed? |
waveywaves
force-pushed
the
fix/dns1123-error-masking
branch
from
2c1b24b to
7fb43ea
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/attestation/crafter/crafter.go">
<violation number="1" location="pkg/attestation/crafter/crafter.go:670">
P2: DNS-1123 invalid-name errors are generic errors and are not treated as terminal in auto-detect, so they are retried and wrapped by the generic auto-discovery failure instead of being surfaced immediately.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
The material auto-discovery loop in AddMaterialContactFreeWithAutoDetectedKind silently swallowed DNS-1123 validation errors because: 1. Variable shadowing: `m, err :=` inside the for loop created a new `err` that never propagated to the outer scope, so the final error message was always nil when all kinds failed. 2. No early validation: invalid material names (uppercase, underscores, dots) were passed through the entire kind-probing loop before failing deep in proto validation, with the real cause buried. 3. Proto-validation errors not detected: the loop treated schema-level validation failures the same as kind mismatches, continuing to probe instead of stopping. Fixes: - Replace `:=` with `=` to avoid shadowing the outer `err` - Add DNS-1123 regex check at the top of AddMaterialContractFree - Detect protovalidate.ValidationError in the auto-discovery loop and break immediately instead of masking the real error Fixes chainloop-dev#2394 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
waveywaves
force-pushed
the
fix/dns1123-error-masking
branch
from
7fb43ea to
a1b71af
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddMaterialContactFreeWithAutoDetectedKind: them, err :=inside the for loop created a newerrthat never propagated to the outer scope, so the final fallthrough error was always nilAddMaterialContractFreeusing a regex check matching the same rule as the proto CEL constraint, returning a clear error message immediately instead of letting invalid names flow through the auto-discovery loopprotovalidate.ValidationErrorin the auto-discovery loop and break early, since schema-level validation failures (like invalid names) are not kind mismatches and should not be retried across all material typesFixes #2394
Test plan
non-dns-1123 name surfaces clear error(name with underscores and dots)uppercase name surfaces dns-1123 error(uppercase letters)TestAddMaterialsAutomatictests continue to pass (12/12)go test ./pkg/attestation/crafter/...passesgo vet ./pkg/attestation/crafter/...passeschainloop att add --value <file> --name My_Invalid.Namethat a clear error is shown🤖 Generated with Claude Code