sbom: make internal SPDX relationships reproducible - #2439
Merged
xnox merged 1 commit intoAug 27, 2026
Conversation
Sort the top-level elements copied from internal APK SBOMs before adding their relationships to the image SBOM. This prevents equivalent builds from producing different predicates due to Go map iteration order.
kevinmdavis
requested review from
markusthoemmes and
wlynch
and removed request for
wlynch
August 27, 2026 22:30
jdolitsky
approved these changes
Aug 27, 2026
xnox
approved these changes
Aug 27, 2026
xnox
left a comment
xnox
left a comment
Member
There was a problem hiding this comment.
Note, syft enumeration of components is often unstable. When this happens we report bugs to them, but yes overall we too should use stable sort even when syft isn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the top-level elements copied from internal APK SBOMs before adding their relationships to the image SBOM. This prevents equivalent builds from producing different predicates due to Go map iteration order.