[players] Stop resizes from corrupting text notes in editing - #2176
Merged
Conversation
A canvas resize while a text note was still in editing corrupted the stored annotation: the reload triggered by the resize cleared the canvas, fabric's clear() exited the editing session and fired object:modified after setDimensions, so the note was serialized with its old-box coordinates against the new dimensions. left/top/scaleX were multiplied by the resize ratio and the note rendered off-canvas for everyone, while its timeline mark survived. Exit text editing before setDimensions so the final text is saved against matching dimensions, and mute onObjectModified during programmatic clears like onObjectAdded and onErasingEnd already were. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution