Skip to content

add int64 type conversion to sourdump encode and decode - #56

Open
gitmpr wants to merge 1 commit into
cfoust:mainfrom
gitmpr:int64-conversion
Open

add int64 type conversion to sourdump encode and decode#56
gitmpr wants to merge 1 commit into
cfoust:mainfrom
gitmpr:int64-conversion

Conversation

@gitmpr

@gitmpr gitmpr commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

fixes the sourdump go build for me using go version go1.23.2 linux/amd64 which might be more strict on requiring explicit int64 types than go version go1.23.3 linux/amd64 that is used in CI to build sourdump

/sour/assets](main)$ bash -x setup
+++ dirname setup
++ cd .
++ pwd
+ SCRIPT_DIR=/home/mpr/git/sourfork/sour/assets
+ cd /home/mpr/git/sourfork/sour/assets
+ set -e
+ mkdir -p cache
+ pip3 list
+ grep cbor2
+ '[' -f sourdump ']'
+ cd ..
+ go build -o assets/sourdump cmd/sourdump/main.go
# github.com/cfoust/sour/pkg/maps
pkg/maps/decode.go:22:47: cannot use i (variable of type int) as int64 value in argument to worldio.CubeArray_getitem
pkg/maps/decode.go:31:68: cannot use j (variable of type int) as int64 value in argument to worldio.SurfaceInfoArray_getitem
pkg/maps/decode.go:41:59: cannot use j (variable of type int) as int64 value in argument to worldio.UcharArray_getitem
pkg/maps/decode.go:47:62: cannot use j (variable of type int) as int64 value in argument to worldio.Uint16Array_getitem
pkg/maps/encode.go:57:37: cannot use i (variable of type int) as int64 value in argument to worldio.CubeArray_setitem```

Atchbo2001 added a commit to Atchbo2001/void-arena that referenced this pull request Aug 3, 2026
Broadcast full SpawnState on respawn so other clients cannot miss visibility after death/respawn cycles. Patch the native map menu catalog at asset build time so custom game creation only shows packaged maps.

Validated by workflow run cfoust#56:
- relay regression tests passed
- gameserver multiplayer regression tests passed
- relay race tests passed
- asset build passed
- WebAssembly engine build passed
- web client build passed
- Go backend build passed
- Linux server binary verification passed
- integrated HTTP/WebSocket smoke test passed
- flat Pterodactyl package artifact uploaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant