Repository navigation
0.5.4 - #1152
Draft
johannes-wolf wants to merge 6 commits into
Draft
0.5.4#1152johannes-wolf wants to merge 6 commits into
johannes-wolf wants to merge 6 commits into
Conversation
Resolve the merge-path styling root and inherit the existing top-level stroke, fill, fill-rule and mark defaults. Add a drawable-property regression for named styles, inheritance and inline overrides, and document the styling root. Fixes #755 Signed-off-by: Don Yin <Don_Yin@outlook.com>
Fixes #755. `merge-path` was resolving the top-level style, so `set-style(merge-path: (...))` had no effect. This adds a `merge-path` styling root with inherited defaults and documents it. Inline styles still take precedence. The new regression checks stroke, fill, fill-rule and marks, including inheritance and inline overrides. On `83c0015`, the suite has 118 passes and only the new test fails; with this change, all 119 pass. Checked with Typst 0.15.1 and tytanic 0.4.1: - `tt run --no-fail-fast` - Direct compilation of the regression test - Package installation, manual compilation and documentation generation using the `justfile` recipes - `git diff --check` The comparison below reads the final drawable's stroke width for the same 3 pt request, set globally, at the named root, or inline ([probe and data](https://github.com/Don-Yin/cetz/tree/4e6f345e584b3c81dd296de9bc7dbc2d217fb85d)). 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.