chore(lint): adopt eslint flat config with naming-convention policy#821
Merged
lcottercertinia merged 2 commits intoJun 19, 2026
Merged
Conversation
- replace tseslint.config + manual @typescript-eslint/parser with defineConfig/globalIgnores, scoping lint to **/*.ts so `eslint .` skips unconfigured js/mjs/cjs - add structured @typescript-eslint/naming-convention selectors (PascalCase imports/consts, null format for external-data object keys) in place of the blanket warn - drop now-redundant `eslint-disable naming-convention` comments across timeline, soql, and salesforce modules the new policy permits - remove @typescript-eslint/parser dep (now transitive via typescript-eslint) and switch the lint script to `eslint . --cache`
lcottercertinia
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Migrates ESLint to the flat config format (
defineConfig/globalIgnores) and replaces the blanketnaming-convention: warnwith a structured policy. This lets the codebase drop a scattering ofeslint-disable @typescript-eslint/naming-conventioncomments and scopes linting to TypeScript only, soeslint .no longer silently scans unconfigured.js/.mjsfiles.🛠️ Changes made
eslint.config.mjsto flatdefineConfig/globalIgnores; pinfiles: ['**/*.ts']soeslint .skips.js/.mjs/.cjs(which would otherwise be scanned with no rules).@typescript-eslint/naming-conventionpolicy: PascalCase imports/consts, UPPER_CASE static readonly fields, andformat: nullfor object keys that mirror external data (Salesforce fields, Apex event names).eslint-disable naming-conventioncomments across the timeline, soql, salesforce, and call-tree modules the new policy legitimately permits.@typescript-eslint/parserdevDependency (now transitive viatypescript-eslint) and switch the lint script toeslint . --cache.🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
N/A — tooling/config only.
✅ Tests added?
📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]
Reviewer note: the substantive change is
eslint.config.mjs; the 18 source/test files are mechanical removals of disable comments (plus a feweqeqeq/prefer-const/any→unknownfixes the stricter config surfaced).pnpm lintpasses with 0 errors.