feat(data-grid): use codicon chevrons for group and tree controls#820
Draft
lukecotter wants to merge 1 commit into
Draft
feat(data-grid): use codicon chevrons for group and tree controls#820lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
- replace upstream's border-triangle group-header arrow with codicon chevron-right/down via ::before - replace boxed +/- data-tree control with the same chevrons, keeping the 16px footprint so tree indentation is unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Replaces Tabulator's stock group-header and data-tree expand/collapse controls with VS Code codicon chevrons, so the call-tree, SOQL, and DML grids match the native VS Code tree look instead of upstream's border-triangle arrows and boxed
+/−buttons.🛠️ Changes made
.tabulator-arrowborder-triangle with a codicon chevron (right = collapsed, down = expanded) drawn via::before.+/−.tabulator-data-tree-controlwith the same chevrons, keeping the 16px footprint so tree indentation is unchanged.codicon-chevronmixin and the codepoints into$codicon-chevron-right/$codicon-chevron-downvariables.🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
Will add before/after after opening.
✅ Tests added?
📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]
TODO: