chore(deps): update module github.com/google/cel-go to v0.29.0 [security]#132
chore(deps): update module github.com/google/cel-go to v0.29.0 [security]#132renovate[bot] wants to merge 1 commit into
Conversation
…ity] Signed-off-by: Renovate Bot <renovate-bot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @renovate[bot]. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR contains the following updates:
v0.26.0→v0.29.0cel-go: JSON Private Fields Exposed via NativeTypes and ParseStructTag
GHSA-gcjh-h69q-9w9g
More information
Details
The function
ext.NativeTypes(ParseStructTag("json"))does not honour theencoding/jsonskip directivejson:"-". Fields taggedjson:"-"are registered in the CEL type system under the literal name"-"and are readable from any user-submitted CEL expression viadyn(obj)["-"].Additionally,
newNativeTypessilently registers every nested struct reachable from the type passed toNativeTypes, including types from third-party dependencies the developer never examined.Root cause
In
fieldNameByTag, the helper used byParseStructTag("json")to translate Go struct tags into CEL field names.See at
ext/native.go:146:For a field tagged
json:"-", this code splits the tag into[]string{"-"}and returns"-"as the CEL field name. It never checks whether"-"is the JSON skip sentinel.This contradicts the
encoding/jsonrule that the source comment explicitly points readers to:The public option also documents JSON-style parsing as the intended behavior.
See at
ext/native.go:190:A developer using
ParseStructTag("json")is therefore led to expectencoding/jsonfield-name semantics. Instead,json:"-"is treated as a real field name.The bad name is accepted during native type construction.
newNativeTypechecks for duplicate field names, but it does not reject or skip empty names or skip sentinels.See at
ext/native.go:663:Once accepted, the field becomes part of CEL's view of the type. Field enumeration reports it as a normal field name.
See at
ext/native.go:286:Field lookup also treats the name as valid and returns the underlying Go field value.
See at
ext/native.go:303:At runtime, native objects advertise index access.
See at
ext/native.go:37:Because
traits.IndexerTypeis present, a user expression can bypass ordinary field syntax and read the registered"-"field with bracket access:The same mistaken name is also used when converting native objects to JSON-like CEL values.
ConvertToNative(jsonStructType)iterates all Go struct fields, computes the CEL field name, and inserts it into the output map without applying the JSON skip rule.See at
ext/native.go:501:This means a
json:"-"secret is exposed in two ways: it can be read directly through CEL indexing asdyn(obj)["-"], and it can appear under the key"-"in JSON struct conversion output.The blast radius is widened by
newNativeTypes, which registers not only the type explicitly passed toNativeTypes, but also every nested struct reachable from its fields.See at
ext/native.go:609:As a result, a developer can register one apparently safe request type while a nested dependency type is silently registered too. If that nested type contains a
json:"-"secret, CEL still receives a readable field named"-"even though the developer never registered or audited that nested type directly.Reproduction
Expected: expression compile error or empty result;
json:"-"field should not beaccessible.
Actual:
sk-live-s3cr3t; the server-injected secret is returned verbatim.The same field is also included under key
"-"inConvertToNative(jsonStructType)output, and appears in
FindStructFieldNamesenumeration.path 1. CEL indexing
Tested against the released module
github.com/google/cel-go v0.28.1(latest stable release as of 2026-05-12), using the
go.modentry:Running the PoC above (
go run main.go) produces:The secret value is returned verbatim, with no error at compile time or at runtime.
Path 2.
ConvertToNative(jsonStructType)When the
nativeObjfor theAuthCtxvalue is converted to a ProtobufStruct(the representation used whenever CEL output is serialised to JSON), the
json:"-"field appears in the output map under the key"-".Running the PoC above produces:
The
"-"key is present in the serialised Protobuf struct alongsideuserId.Any system that converts a CEL evaluation result to JSON (e.g. via
structpb.Struct) will include the secret in the output, regardless of whether thedyn()["-"]indexing path is used.Impact
Any user who can submit CEL expressions to an application that uses
ext.NativeTypes(ParseStructTag("json"))can read struct fields that the developer explicitly markedjson:"-"to keep out of serialised output. By writingdyn(obj)["-"], the attacker retrieves the raw Go field value, typically a secret, internal token, or private identifier, with no compile-time or runtime error. BecausenewNativeTypessilently registers every nested struct reachable from the root type, the attacker may also reach secrets in dependency types the developer never intended to expose to CEL.Remediation
Do not treat
json:"-"as a CEL field named"-". Model it as an explicit skipped field, not as an empty string field name.Update the struct-tag parsing path so exact
json:"-"returns “skip this field”, whilejson:"-,"continues to mean the literal field name"-", matchingencoding/jsonsemantics.Apply that skip decision consistently anywhere native fields are exposed or resolved:
newNativeTypeFindStructFieldNamesFindStructFieldTypefieldByName/hasFieldNewValueConvertToNative(jsonStructType)Apply the same omit handling for
xml:"-",yaml:"-", andbson:"-"whereParseStructTagis used.Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:L/VI:N/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
google/cel-go (github.com/google/cel-go)
v0.29.0Compare Source
What's Changed
New Features
extlibrary for JSON encoding by @rohan-patnaik in cel-expr#1340network.IP/CIDRsupport from Kubernetes by @tdesrosi in cel-expr#1238InterpretableV2by @TristonianJones in cel-expr#1344Bug Fixes
has()unknown propagation during partial evaluation by @0xASTRA in cel-expr#1324indexOfandlastIndexOfby @alhudz in cel-expr#1335int32/uint32map key narrowing inqualifyInternalby @alhudz in cel-expr#1337genRange()inext/liststo prevent OOM by @marwan9696 in cel-expr#1310Cost Tracking
startsWith/endsWithruntime cost agreement with checked cost by @TristonianJones in cel-expr#1351Testing & Tooling
Documentation
v0.28.1Compare Source
What's Changed
IntToDurationoverload by @alexsnaps in #1300New Contributors
Full Changelog: cel-expr/cel-go@v0.28.0...v0.28.1
v0.28.0Compare Source
High-Level Changes
cel.Issuesand more descriptive, context-aware error messages.🚀 Features
cel.Issuesin #1267env.Configvalues where reasonable in #1273NewEnvin #1275🐞 Bug Fixes
optional.orand.orValueimpl in #1276🛠️ Maintenance & Internal
Full Changelog: https://github.com/google/cel-go/compare/v0.27.0...v0.28.0-alpha
v0.27.0Compare Source
Release Summary
This release focuses on improving developer tooling and stability. Key highlights include significant enhancements to the REPL (YAML configuration support and parse-only evaluation), the addition of cost estimation for regex operations, and improved test coverage reporting.
On the stability front, this release addresses race conditions in reference types, improves namespace resolution, and ensures formatting directives align strictly with the CEL specification.
Note: This release includes a breaking change regarding how types are handled as variables. Please review the "Breaking Changes" section below.
⚠ Breaking Changes
Remove types as variables: The logic for handling types has been relaxed to support safe rollout of feature packages which introduce new types whose names may collide with existing variables. Please review your policies if you relied on types behaving strictly as variables in previous versions. PR #1262
Features & Enhancements
REPL & Tooling
YAML Configuration: The REPL now supports reading and writing YAML environment configurations. PR #1250
Parse-Only Mode: Added parse-only evaluation capabilities to the REPL. PR #1254
Test Coverage: Introduced logic for CEL test coverage calculation and updated the reporter to handle error/unknown scenarios.PR #1209 & PR #1215
Core Library
Regex Costing: Added support for cost estimation and tracking within the regex library. PR #1200
JSON Type Exposure: Exposed CEL JSON types to assist developers in converting to native values. PR #1261
Policy Composition: Source information is now preserved during CEL policy composition, aiding in debugging. PR #1253
Extensibility:
Updated extension option factory to resolve by ID (#1249).
Refactored match output compiling to accept user-defined logic (#1246).
Exposed Match source ID to callers (#1227).
Build & Maintenance
Bazel: Migrated to use Bazel module only and improved configuration for dependent builds. PR #1231 & PR #1228
Cleanup: Removed strcase dependency, removed AppEngine code from REPL, and performed general linting. PR #1230, #1216, #1251
Bug Fixes
Concurrency: Fixed a race condition in the checker regarding reference types. PR #1224
Namespace Resolution: Addressed an issue with namespace resolution. PR #1256
Spec Compliance: Fixed formatting directives to fully support requirements documented in the cel-spec. PR #1232
New Contributors
Full Changelog: cel-expr/cel-go@v0.26.1...v0.27.0
v0.26.1Compare Source
What's Changed
proto.Messageby @srikrsna in #1207New Contributors
Full Changelog: cel-expr/cel-go@v0.25.1...v0.26.1
Configuration
📅 Schedule: (in timezone Europe/London)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.