Repository navigation
Conversation
…rity docs Refuse an RSA key of fewer than 2048 bits when the key is made, with InvalidRequestException, as an ECDSA key on another curve is: connection, subscription and API tokens and JWKS all take their keys from Key. A broadcast being retried when the client closes now fails its next attempt with ClosedException, so the exception keeps every channel's outcome, instead of throwing a bare ClosedException after the wait. Test close() during a call, calls and batches after it, close() called again, and the retry stopping. Name the ways to keep proxy endpoints reachable by Centrifugo only: a network of their own, a secret header from the proxy's static_headers, TLS. The docs now say spec 0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpcent following spec 0.4 (centrifugal/gocent#27).
Key::rsarefuses keys under 2048 bits withInvalidRequestExceptionwhen the key is made, asKey::ecdsarefuses another curve.fromPemgoes through it, so connection, subscription and API tokens and JWKS are all covered. Tested with a 1024-bit key as an OpenSSL key, a PEM string and throughfromPem.close()runs still gets its reply, and later calls and batches throwClosedException; a broadcast being retried stops at its next attempt. Concurrent closes and auto-batching don't apply to phpcent.onAttemptErrorclosed the client,broadcastWithRetrythrew a bareClosedExceptionand lost the outcomes of earlier attempts. Now the next attempt fails withClosedExceptionlike any attempt no retry can fix, so each channel keeps its outcome, as in gocent.static_headers, TLS.composer checkpasses, and so does the PRO integration suite (PHPCENT_TEST_PRO=1 composer test-integration).