Repository navigation
feat!: plain search words, and filters as chips in the search field - #1674
Merged
Merged
Conversation
A search is now plain words that must all match. The search grammar goes: parse-search-query.ts, containsWord, wordSearchFilter, MatchMode and the mode arguments. parseTerms also splits on commas. SearchChipsField shows every word and filter as a chip with its own X, offers the filters from a popover, and suggests while typing. TableBarShell takes searchFilters where it took filters, so members, users, entity grids and docs operations use it; a list without filters keeps the plain SearchField. The results count sits in the field, and the close X replaces Cancel on a phone. useMatchSteps moves to the docs module with the one find that keeps stepping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A board or feed searches as its main control: the field fills the row, and a phone's closed row shows it as a field that opens the same panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template half of the search rethink. raak already stopped using the removed helpers (cellajs/raak#242).
What changes
parse-search-query.ts,containsWord,wordSearchFilter,MatchModeand themodearguments go, andparseTermsalso splits on commas.SearchChipsField: every word and filter is its own chip with its own X. A space, comma, Enter or leaving the field turns the word into a chip. An empty input offers the filters and recent searches; an input with text suggests matches. Backspace brings a keyword back to edit.TableBarShelltakessearchFilterswhere it tookfilters. Members, users, entity grids and docs operations use it, andSelectRoleis gone. A list with no filters keeps the plainSearchField.useMatchStepsand the step buttons move todocs/find-steps.tsx, for the OpenAPI find.navigationStoregainsrecentListSearchesfor lists with filters. No template list uses it yet: raak and projectcampus do next.Ships alignment
20261031T1009-search-chips.Verification
pnpm check,pnpm styleandpnpm unusedare clean, apart from an existing linter info note andpnpm unused's config hints.text-matchandrecent-searches, thesearch-filterbackend test (browser and database agree), and thetable-bar-shellandmatch-highlightstories pass.qandrole.Size
search-chips-field.tsx(about 410 lines, almost no comments), which replaces raak's and projectcampus's own search fields in the next steps, against the search grammar and role select removed here.🤖 Generated with Claude Code