Skip to content

Update dependency dev.zacsweers.metro:dev.zacsweers.metro.gradle.plugin to v1 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdsap merged 2 commits into from
May 5, 2026
Merged

Update dependency dev.zacsweers.metro:dev.zacsweers.metro.gradle.plugin to v1 #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa6d117
Update dependency dev.zacsweers.metro:dev.zacsweers.metro.gradle.plug…
renovate[bot] May 5, 2026
404c427
Skip Metro DI variant on JDK 17 in E2E tests
cdsap May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/model/Versions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ data class Android(
val hilt: String = "2.59.2",
val hiltAandroidx: String = "1.3.0",
val metro: String = "1.0.0",
val metroPlugin: String = "0.10.2",
val metroPlugin: String = "1.0.0",
val composeBom: String = "2026.04.01",
val robolectric: String = "4.16.1",
val espresso: String = "3.7.0",
Expand Down
9 changes: 7 additions & 2 deletions ...in/io/github/cdsap/projectgenerator/AndroidKotlinMultiplatformLibraryE2EValidationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import io.github.cdsap.projectgenerator.model.Versions
import io.github.cdsap.projectgenerator.writer.GradleWrapper
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Assumptions.assumeFalse
import org.junit.jupiter.api.io.TempDir
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.EnumSource
Expand All @@ -28,6 +29,8 @@ class AndroidKotlinMultiplatformLibraryE2EValidationTest {
@ParameterizedTest
@EnumSource(DependencyInjection::class)
fun `android kotlin multiplatform library project assembles for all di modes`(di: DependencyInjection) {
val jdk = "17"
assumeFalse(di == DependencyInjection.METRO && jdk == "17", "Metro is not supported on JDK 17")
val projectName = "android_kmp_library_e2e_${di.name.lowercase()}"
ProjectGenerator(
modules = 6,
Expand All @@ -36,7 +39,7 @@ class AndroidKotlinMultiplatformLibraryE2EValidationTest {
typeOfProjectRequested = TypeProjectRequested.ANDROID,
classesPerModule = ClassesPerModule(ClassesPerModuleType.FIXED, 10),
versions = Versions(
project = Project(jdk = "17"),
project = Project(jdk = jdk),
di = di,
android = Android(kotlinMultiplatformLibrary = true)
),
Expand All @@ -56,6 +59,8 @@ class AndroidKotlinMultiplatformLibraryE2EValidationTest {
@ParameterizedTest
@EnumSource(DependencyInjection::class)
fun `android kotlin multiplatform library with room project assembles for all di modes`(di: DependencyInjection) {
val jdk = "17"
assumeFalse(di == DependencyInjection.METRO && jdk == "17", "Metro is not supported on JDK 17")
val projectName = "android_kmp_library_room_e2e_${di.name.lowercase()}"
ProjectGenerator(
modules = 6,
Expand All @@ -64,7 +69,7 @@ class AndroidKotlinMultiplatformLibraryE2EValidationTest {
typeOfProjectRequested = TypeProjectRequested.ANDROID,
classesPerModule = ClassesPerModule(ClassesPerModuleType.FIXED, 10),
versions = Versions(
project = Project(jdk = "17"),
project = Project(jdk = jdk),
di = di,
android = Android(
kotlinMultiplatformLibrary = true,
Expand Down
5 changes: 4 additions & 1 deletion ...c/test/kotlin/io/github/cdsap/projectgenerator/RoomDiVariantsAssembleE2EValidationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import io.github.cdsap.projectgenerator.model.Versions
import io.github.cdsap.projectgenerator.writer.GradleWrapper
import org.gradle.testkit.runner.GradleRunner
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Assumptions.assumeFalse
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.EnumSource
import org.junit.jupiter.api.io.TempDir
Expand All @@ -28,6 +29,8 @@ class RoomDiVariantsAssembleE2EValidationTest {
@ParameterizedTest
@EnumSource(DependencyInjection::class)
fun `room builds debug and release with assemble for all di modes`(di: DependencyInjection) {
val jdk = "17"
assumeFalse(di == DependencyInjection.METRO && jdk == "17", "Metro is not supported on JDK 17")
val projectName = "room_assemble_${di.name.lowercase()}"
ProjectGenerator(
modules = 8,
Expand All @@ -36,7 +39,7 @@ class RoomDiVariantsAssembleE2EValidationTest {
typeOfProjectRequested = TypeProjectRequested.ANDROID,
classesPerModule = ClassesPerModule(ClassesPerModuleType.FIXED, 12),
versions = Versions(
project = Project(jdk = "17"),
project = Project(jdk = jdk),
di = di,
android = Android(roomDatabase = true)
),
Expand Down
Loading