Repository navigation
Remove single trailing newlines from strict subtitle content - #105
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
AI-assisted by Codex (GPT-6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_legal_content("caption\n")currently returns the trailing newline unchanged because its fast path only checks the first character and internal blank lines. Consequently, strictSubtitle.to_srt()andcompose()emit three newlines after that cue instead of the usual two.Check the last character before taking the fast path, so this input uses the existing boundary-newline normalization. Legal multiline content and horizontal whitespace are preserved; non-strict output is unchanged.
Validation on macOS with Python 3.9.6:
to_srt()andcompose(), non-strict controls, Unicode, and whitespace preservation.srt.py.C0330option and two existing positional-argument warnings. The full OS/Python CI matrix was not run locally.AI assistance: This patch, tests and description were prepared with Codex (GPT-6).