feat(auto-review): bound background review execution#377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #369.
Why
The July 17-18 dogfood run showed that detached Background Review could continue for roughly 17 minutes, consume about 2.55 million reported tokens, and surface a finding after the primary agent had already handed off. Background Review needs predictable ceilings and an explicit disposition workflow before Codex Lab can rely on it during normal dogfood.
What changed
needs_attention,repairing,deferred, orobsoletedisposition state.auto_review_dispositionsupport plusreview/disposition/write, bounded repair detail, app-server schemas, and API documentation.Validation
cargo check -j 1 -p codex-auto-review -p codex-app-server-protocol -p codex-app-server -p codex-config -p codex-core -p codex-rollout -p codex-thread-store -p codex-tuiDogfood proof
0e3eb23201b06767c27dbc299e41206ec935c81167ca3c1b186639c917d1516ade19778108f16ce21bbadcaf6f9680ed3c0ef05734026fd7-6645-4f57-9185-1553a5eba17ccodex-auto-review(mediumreasoning)completedrun with[P1] Clamp remaining budget instead of subtracting raw u64sobsolete, actoragent, reasondeliberate disposable dogfood fixture; not a production change.