perf(ordinal-patterns): serial path for small data and bypass decorator overhead - #53
Merged
Merged
Conversation
Merging this PR will improve performance by ×3.5
Performance Changes
Tip Curious why this is faster? Comment Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 842 849 +7
Branches 151 152 +1
=========================================
+ Hits 842 849 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes to the COP (Continuous Ordinal Patterns) connectivity metric:
Serial path for small data:
norm_windowsandpattern_distanceused numbaparallel=Truewithprange, spawning OpenMP threads on every call. For small benchmark data (ts_len=50, p_size=3 -> 48 windows), 91% of execution time was OpenMP thread synchronization. Split each into serial (@njitwithrange) and parallel (@njitwithprange) variants, with a plain-Python dispatcher choosing the serial path whenn_windows < 200.pattern_transform_2dno longer needs@njitsince it delegates to the dispatchers.Decorator bypass:
random_patternscalledgt_multi_lag(wrapped in@connectivity) inside its per-pattern loop, incurringinspect.signature().bind()overhead for every random pattern. Callfind_optimal_lag(gt_single_lag, ...)directly instead. No redundant validation.Also adds two test types:
norm_windowsandpattern_distanceagainst a numpy independent reference implementation.